From: Guenter Roeck <linux@roeck-us.net>
To: lm-sensors@vger.kernel.org
Subject: Re: [lm-sensors] [RFT][PATCH 1/2] hwmon: (da9052) Convert to devm_hwmon_device_register_with_groups
Date: Wed, 09 Jul 2014 00:34:30 +0000 [thread overview]
Message-ID: <53BC8E16.4010400@roeck-us.net> (raw)
In-Reply-To: <1404010388.5607.1.camel@phoenix>
On 07/08/2014 05:27 PM, Axel Lin wrote:
> 2014-07-08 22:07 GMT+08:00 Guenter Roeck <linux@roeck-us.net>:
>> On 06/28/2014 07:53 PM, Axel Lin wrote:
>>>
>>> Use ATTRIBUTE_GROUPS macro and devm_hwmon_device_register_with_groups() to
>>> simplify the code a bit.
>>>
>>> Signed-off-by: Axel Lin <axel.lin@ingics.com>
>>
>>
>> I'll need a Tested-by: to apply this patch.
> Indeed. I think I'll try to CC more people when send v2.
>>
>>
>>> ---
>>> Note, devm_hwmon_device_register_with_groups does not allow "-" in the
>>> name
>>> argument. So there is a change in 'name' attribute.
>>> It was "da9052-hwmon", and now it's "da9052".
>>
>>
>> It might be worthwhile to send a separate patch to address this problem.
> I know devm_hwmon_device_register_with_groups does not allow "-" in
> the name argument,
> but I don't know why.
> So I'm wondering if current code which use "da9052-hwmon" in name
> attribute causes any problem?
>
Yes, it does. Dashes are not allowed in hwmon name attributes.
See Documentation/hwmon-sysfs-interface. Dashes interfer with
name decoding in libsensors.
Guenter
_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors
prev parent reply other threads:[~2014-07-09 0:34 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-29 2:53 [lm-sensors] [RFT][PATCH 1/2] hwmon: (da9052) Convert to devm_hwmon_device_register_with_groups Axel Lin
2014-07-08 14:07 ` Guenter Roeck
2014-07-09 0:27 ` Axel Lin
2014-07-09 0:34 ` Guenter Roeck [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53BC8E16.4010400@roeck-us.net \
--to=linux@roeck-us.net \
--cc=lm-sensors@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.