All of lore.kernel.org
 help / color / mirror / Atom feed
From: Hannes Reinecke <hare@suse.de>
To: Christoph Hellwig <hch@infradead.org>,
	Dick Kennedy <Dick.Kennedy@Emulex.Com>
Cc: "linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>
Subject: Re: [PATCH 1/1] Add defines for new FC port speeds.
Date: Wed, 09 Jul 2014 12:47:44 +0200	[thread overview]
Message-ID: <53BD1DD0.4000105@suse.de> (raw)
In-Reply-To: <20140625105738.GA19049@infradead.org>

On 06/25/2014 12:57 PM, Christoph Hellwig wrote:
> Can I get another review for this one?
>
> On Fri, Jun 13, 2014 at 04:40:36PM +0000, Dick Kennedy wrote:
>> These speeds are to support the next generation of FCoE port speeds.
>> Signed-off-by: rkennedy@emulex.com
>> ---
>>   drivers/scsi/scsi_transport_fc.c |    4 ++++
>>   include/scsi/scsi_transport_fc.h |    4 ++++
>>   2 files changed, 8 insertions(+), 0 deletions(-)
>>
>> diff --git a/drivers/scsi/scsi_transport_fc.c b/drivers/scsi/scsi_transport_fc.c
>> index f80908f..454cc28 100644
>> --- a/drivers/scsi/scsi_transport_fc.c
>> +++ b/drivers/scsi/scsi_transport_fc.c
>> @@ -262,6 +262,10 @@ static const struct {
>>          { FC_PORTSPEED_8GBIT,           "8 Gbit" },
>>          { FC_PORTSPEED_16GBIT,          "16 Gbit" },
>>          { FC_PORTSPEED_32GBIT,          "32 Gbit" },
>> +       { FC_PORTSPEED_20GBIT,          "20 Gbit" },
>> +       { FC_PORTSPEED_40GBIT,          "40 Gbit" },
>> +       { FC_PORTSPEED_50GBIT,          "50 Gbit" },
>> +       { FC_PORTSPEED_100GBIT,         "100 Gbit" },
>>          { FC_PORTSPEED_NOT_NEGOTIATED,  "Not Negotiated" },
>>   };
>>   fc_bitfield_name_search(port_speed, fc_port_speed_names)
>> diff --git a/include/scsi/scsi_transport_fc.h b/include/scsi/scsi_transport_fc.h
>> index 8c79980..007a0bc 100644
>> --- a/include/scsi/scsi_transport_fc.h
>> +++ b/include/scsi/scsi_transport_fc.h
>> @@ -131,6 +131,10 @@ enum fc_vport_state {
>>   #define FC_PORTSPEED_8GBIT             0x10
>>   #define FC_PORTSPEED_16GBIT            0x20
>>   #define FC_PORTSPEED_32GBIT            0x40
>> +#define FC_PORTSPEED_20GBIT            0x80
>> +#define FC_PORTSPEED_40GBIT            0x100
>> +#define FC_PORTSPEED_50GBIT            0x200
>> +#define FC_PORTSPEED_100GBIT           0x400
>>   #define FC_PORTSPEED_NOT_NEGOTIATED    (1 << 15) /* Speed not established */
>>
>>   /*
>> --
>> 1.6.6

Reviewed-by: Hannes Reinecke <hare@suse.de>

Cheers,

Hannes
-- 
Dr. Hannes Reinecke		      zSeries & Storage
hare@suse.de			      +49 911 74053 688
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: J. Hawn, J. Guild, F. Imendörffer, HRB 16746 (AG Nürnberg)
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

  reply	other threads:[~2014-07-09 10:47 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-06-13 16:40 [PATCH 1/1] Add defines for new FC port speeds Dick Kennedy
2014-06-13 16:45 ` Christoph Hellwig
2014-06-25 10:57 ` Christoph Hellwig
2014-07-09 10:47   ` Hannes Reinecke [this message]
2014-06-25 12:55 ` Ewan Milne

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=53BD1DD0.4000105@suse.de \
    --to=hare@suse.de \
    --cc=Dick.Kennedy@Emulex.Com \
    --cc=hch@infradead.org \
    --cc=linux-scsi@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.