From mboxrd@z Thu Jan 1 00:00:00 1970 From: Keerthy Subject: Re: [PATCH V2 2/2] ARM: dts: DRA7: Add node for RTC Date: Wed, 9 Jul 2014 16:26:03 +0530 Message-ID: <53BD1FC3.6050500@ti.com> References: <1404894932-26677-1-git-send-email-lokeshvutla@ti.com> <1404894932-26677-3-git-send-email-lokeshvutla@ti.com> <20140709091232.GJ28884@atomide.com> <53BD0C43.1090002@ti.com> <20140709100914.GL28884@atomide.com> <53BD1AF8.2060609@ti.com> <20140709105055.GP28884@atomide.com> Mime-Version: 1.0 Content-Type: text/plain; charset="ISO-8859-1"; format=flowed Content-Transfer-Encoding: 7bit Return-path: Received: from devils.ext.ti.com ([198.47.26.153]:35496 "EHLO devils.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751345AbaGIK6Q (ORCPT ); Wed, 9 Jul 2014 06:58:16 -0400 In-Reply-To: <20140709105055.GP28884@atomide.com> Sender: linux-omap-owner@vger.kernel.org List-Id: linux-omap@vger.kernel.org To: Tony Lindgren Cc: Lokesh Vutla , paul@pwsan.com, linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org, rnayak@ti.com, devicetree@vger.kernel.org, nm@ti.com, j-keerthy@ti.com, nsekhar@ti.com On Wednesday 09 July 2014 04:20 PM, Tony Lindgren wrote: > * Keerthy [140709 03:39]: >> On Wednesday 09 July 2014 03:39 PM, Tony Lindgren wrote: >>> * Keerthy [140709 02:36]: >>>> On Wednesday 09 July 2014 02:42 PM, Tony Lindgren wrote: >>>>> * Lokesh Vutla [140709 01:37]: >>>>>> --- a/arch/arm/boot/dts/dra7-evm.dts >>>>>> +++ b/arch/arm/boot/dts/dra7-evm.dts >>>>>> @@ -249,6 +249,7 @@ >>>>>> regulator-min-microvolt = <1050000>; >>>>>> regulator-max-microvolt = <1050000>; >>>>>> regulator-boot-on; >>>>>> + regulator-always-on; >>>>>> }; >>>>> Is this regulator really always on? >>>> This feeds on to RTC which is a free running clock. So i guess always on is >>>> justified no? >>> Well the dts entries should describe the hardware. If the >>> regulator can be enabled and disabled, we should not claim it's >>> always on. >> From the PMIC perspective every regulator can be enabled and >> disabled. From a Board perspective there are some which need >> to be always on. For Ex: SMPS123 which feeds on to the MPU. > Right, and we already have regulator-boot-on for those. Or are > you seeing some issue with that? regulator-boot-on describes that at boot a particular regulator is on. It does not guarantee that it will be on for the rest of the time. The regulator framework can go ahead and disable it if no one has requested for it. In case of RTC we do not want that to happen. > >> I guess RTC also needs the supply to be on as long as we want >> the clock to be ticking. > Sure, but if somebody wants shut it off regulator-boot-on is > better from driver point of view. > > Regards, > > Tony From mboxrd@z Thu Jan 1 00:00:00 1970 From: a0393675@ti.com (Keerthy) Date: Wed, 9 Jul 2014 16:26:03 +0530 Subject: [PATCH V2 2/2] ARM: dts: DRA7: Add node for RTC In-Reply-To: <20140709105055.GP28884@atomide.com> References: <1404894932-26677-1-git-send-email-lokeshvutla@ti.com> <1404894932-26677-3-git-send-email-lokeshvutla@ti.com> <20140709091232.GJ28884@atomide.com> <53BD0C43.1090002@ti.com> <20140709100914.GL28884@atomide.com> <53BD1AF8.2060609@ti.com> <20140709105055.GP28884@atomide.com> Message-ID: <53BD1FC3.6050500@ti.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Wednesday 09 July 2014 04:20 PM, Tony Lindgren wrote: > * Keerthy [140709 03:39]: >> On Wednesday 09 July 2014 03:39 PM, Tony Lindgren wrote: >>> * Keerthy [140709 02:36]: >>>> On Wednesday 09 July 2014 02:42 PM, Tony Lindgren wrote: >>>>> * Lokesh Vutla [140709 01:37]: >>>>>> --- a/arch/arm/boot/dts/dra7-evm.dts >>>>>> +++ b/arch/arm/boot/dts/dra7-evm.dts >>>>>> @@ -249,6 +249,7 @@ >>>>>> regulator-min-microvolt = <1050000>; >>>>>> regulator-max-microvolt = <1050000>; >>>>>> regulator-boot-on; >>>>>> + regulator-always-on; >>>>>> }; >>>>> Is this regulator really always on? >>>> This feeds on to RTC which is a free running clock. So i guess always on is >>>> justified no? >>> Well the dts entries should describe the hardware. If the >>> regulator can be enabled and disabled, we should not claim it's >>> always on. >> From the PMIC perspective every regulator can be enabled and >> disabled. From a Board perspective there are some which need >> to be always on. For Ex: SMPS123 which feeds on to the MPU. > Right, and we already have regulator-boot-on for those. Or are > you seeing some issue with that? regulator-boot-on describes that at boot a particular regulator is on. It does not guarantee that it will be on for the rest of the time. The regulator framework can go ahead and disable it if no one has requested for it. In case of RTC we do not want that to happen. > >> I guess RTC also needs the supply to be on as long as we want >> the clock to be ticking. > Sure, but if somebody wants shut it off regulator-boot-on is > better from driver point of view. > > Regards, > > Tony