From mboxrd@z Thu Jan  1 00:00:00 1970
From: Andrew Cooper <andrew.cooper3@citrix.com>
Subject: Re: [RFC PATCH 3/3] remus: adjust x86 pv restore to
 support remus
Date: Wed, 9 Jul 2014 12:26:24 +0100
Message-ID: <53BD26E0.9030406@citrix.com>
References: <1404892050-24650-1-git-send-email-yanghy@cn.fujitsu.com>	<1404892050-24650-4-git-send-email-yanghy@cn.fujitsu.com>
	<53BD2477.1070505@citrix.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <53BD2477.1070505@citrix.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Yang Hongyang <yanghy@cn.fujitsu.com>, xen-devel@lists.xen.org
Cc: rshriram@cs.ubc.ca, Ian.Jackson@eu.citrix.com, Ian.Campbell@citrix.com
List-Id: xen-devel@lists.xenproject.org

On 09/07/14 12:16, Andrew Cooper wrote:
> On 09/07/14 08:47, Yang Hongyang wrote:
>> cache vcpu context when restore, and set context when stream
>> complete.
> Can you explain why this is needed?  I can't see why it should be required.

Actually, as part of reviewing this I have worked out why this is needed.

It is a latent bug in the migration v2 series with all the x86 pv vcpu
state (not just the basic state), which is not triggered by a well
behaved sender.

I shall fix it up in the base series.

~Andrew