From: Julien Grall <julien.grall@linaro.org>
To: Ian Campbell <ian.campbell@citrix.com>, Anup Patel <apatel@apm.com>
Cc: xen-devel@lists.xensource.com,
Pranavkumar Sawargaonkar <psawargaonkar@apm.com>,
Stefano Stabellini <stefano.stabellini@eu.citrix.com>
Subject: Re: [PATCH v3] xen/arm: introduce PLATFORM_QUIRK_GUEST_PIRQ_NEED_EOI
Date: Wed, 09 Jul 2014 15:43:49 +0100 [thread overview]
Message-ID: <53BD5525.3000203@linaro.org> (raw)
In-Reply-To: <1404916813.11945.29.camel@hastur.hellion.org.uk>
On 07/09/2014 03:40 PM, Ian Campbell wrote:
>> I think we should check GIC Dist address passed in DTS by
>> u-boot to Xen. If GIC Dist address is secured address then
>> enable the quirk otherwise disable the qurik.
>
> Isn't IGROUPR readable from NS? In which case we should be able to spot
> the difference, I think?
>
> Stefano, you might want to arrange in your patch to cache the value of
> the quirk in the gicv2 struct -- otherwise all the calls to
> platform_has_quirk are going to add up.
Can't we cache the value in the platform code? I don't think it's too
expensive to call the platform_has_quirk in this case.
Regards,
--
Julien Grall
next prev parent reply other threads:[~2014-07-09 14:43 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-04 14:39 [PATCH v3] xen/arm: introduce PLATFORM_QUIRK_GUEST_PIRQ_NEED_EOI Stefano Stabellini
2014-07-04 14:44 ` Julien Grall
2014-07-09 12:41 ` Ian Campbell
2014-07-09 13:43 ` Pranavkumar Sawargaonkar
2014-07-09 14:19 ` Stefano Stabellini
2014-07-09 14:24 ` Anup Patel
2014-07-09 14:40 ` Ian Campbell
2014-07-09 14:43 ` Julien Grall [this message]
2014-07-09 15:11 ` Stefano Stabellini
2014-07-10 10:33 ` Ian Campbell
2014-07-10 10:51 ` Anup Patel
2015-04-02 13:45 ` Stefano Stabellini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53BD5525.3000203@linaro.org \
--to=julien.grall@linaro.org \
--cc=apatel@apm.com \
--cc=ian.campbell@citrix.com \
--cc=psawargaonkar@apm.com \
--cc=stefano.stabellini@eu.citrix.com \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.