From: Andrew Cooper <andrew.cooper3@citrix.com>
To: Ian Campbell <ian.campbell@citrix.com>
Cc: Ian Jackson <Ian.Jackson@eu.citrix.com>,
Xen-devel <xen-devel@lists.xen.org>
Subject: Re: [PATCH v2] tools/python: Improve .gitgnore and clean Makefile rule
Date: Wed, 9 Jul 2014 17:07:53 +0100 [thread overview]
Message-ID: <53BD68D9.9060400@citrix.com> (raw)
In-Reply-To: <1404920820.11945.45.camel@hastur.hellion.org.uk>
On 09/07/14 16:47, Ian Campbell wrote:
> On Mon, 2014-07-07 at 11:26 +0100, Andrew Cooper wrote:
>> Ignore all intermediate python files, and use find in the clean rule as there
>> are no Makefiles in subdirectories to participate in a recursive clean.
>>
>> Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
>> CC: Ian Campbell <Ian.Campbell@citrix.com>
>> CC: Ian Jackson <Ian.Jackson@eu.citrix.com>
>> diff --git a/.gitignore b/.gitignore
>> index 562c262..cf9264f 100644
>> --- a/.gitignore
>> +++ b/.gitignore
>> @@ -16,6 +16,7 @@
>> *.spit
>> *.gcno
>> *.gcda
>> +*.py[ocd]
> FWIW there are a bunch of explicit foo.pyc listed which could now be
> removed I guess.
True.
>
>> - rm -f $(XENPATH)
>> - rm -rf build/ *.pyc *.pyo *.o *.a *~ xen/util/auxbin.pyc
>> - rm -f xen/lowlevel/xl/_pyxl_types.h
>> - rm -f xen/lowlevel/xl/_pyxl_types.c
>> - rm -f $(DEPS)
>> + find . \( -name "*.py[ocd]" -o -name "*~" -o -name "_*.[hc]" \) -delete
> I've assumed the lack of *.a in here is deliberate but *.o?
>
> Ian.
>
No object files or libraries will be generated outside of build/
If we wish to cater to devs doing out-of-band builds in subdirectires
then more than .o and .a should be included in this find.
~Andrew
next prev parent reply other threads:[~2014-07-09 16:07 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-07 10:26 [PATCH v2] tools/python: Improve .gitgnore and clean Makefile rule Andrew Cooper
2014-07-09 15:47 ` Ian Campbell
2014-07-09 16:07 ` Andrew Cooper [this message]
2014-07-09 16:49 ` Ian Campbell
2014-07-10 10:33 ` Ian Campbell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53BD68D9.9060400@citrix.com \
--to=andrew.cooper3@citrix.com \
--cc=Ian.Jackson@eu.citrix.com \
--cc=ian.campbell@citrix.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.