All of lore.kernel.org
 help / color / mirror / Atom feed
From: Roald Frederickx <roald.frederickx@gmail.com>
To: platform-driver-x86@vger.kernel.org
Cc: linux-kernel@vger.kernel.org
Subject: [PATCH] compal-laptop: correct invalid hwmon name
Date: Wed, 09 Jul 2014 21:12:42 +0200	[thread overview]
Message-ID: <53BD942A.2070106@gmail.com> (raw)

From: Roald Frederickx <roald.frederickx@gmail.com>

Change the name of the hwmon interface from "compal-laptop" to "compal". 
A dash is an invalid character for a hwmon name and caused the call to 
hwmon_device_register_with_groups() to fail.

Signed-off-by: Roald Frederickx <roald.frederickx@gmail.com>
---

diff --git a/drivers/platform/x86/compal-laptop.c 
b/drivers/platform/x86/compal-laptop.c
index 7297df2..26bfd7b 100644
--- a/drivers/platform/x86/compal-laptop.c
+++ b/drivers/platform/x86/compal-laptop.c
@@ -1028,7 +1028,7 @@ static int compal_probe(struct platform_device *pdev)
  		return err;

  	hwmon_dev = hwmon_device_register_with_groups(&pdev->dev,
-						      DRIVER_NAME, data,
+						      "compal", data,
  						      compal_hwmon_groups);
  	if (IS_ERR(hwmon_dev)) {
  		err = PTR_ERR(hwmon_dev);

             reply	other threads:[~2014-07-09 19:06 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-07-09 19:12 Roald Frederickx [this message]
2014-07-09 20:26 ` [PATCH] compal-laptop: correct invalid hwmon name Guenter Roeck

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=53BD942A.2070106@gmail.com \
    --to=roald.frederickx@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=platform-driver-x86@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.