From mboxrd@z Thu Jan 1 00:00:00 1970 From: Khiem Nguyen Date: Thu, 10 Jul 2014 08:43:55 +0000 Subject: Re: [PATCH v2] ARM: shmobile: Lager: Correct I2C bus for VDD MPU regulator Message-Id: <53BE524B.9000909@renesas.com> List-Id: References: <53B5F327.5040301@renesas.com> In-Reply-To: <53B5F327.5040301@renesas.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: linux-sh@vger.kernel.org On 7/10/2014 5:23 PM, Magnus Damm wrote: > Hi Khiem-san, Wolfram, everyone, > > [CC Wolfram] > > On Fri, Jul 4, 2014 at 2:19 AM, Khiem Nguyen > wrote: >> I2C bus for VDD MPU regulator is IIC3, not I2C3. >> >> Signed-off-by: Khiem Nguyen >> --- >> v2: >> - re-based on top of tag renesas-devel-v3.16-rc3-20140701. >> - removed redundant spaces. > > This patch is changing I2C master controller device for the I2C bus > where the power chip is located. I've heard that all of our different > I2C controllers come with a range of features and issues, so I think > we should check with the I2C maintainer Wolfram Sang about this > matter. > > Wolfram, can you give us your opinion about this patch? Does it > improve our I2C software support on Lager? IICDVFS is used for controlling power chip, according to H2 datasheet. In H2/Lager board, name of IICDVFS is IIC3. This patch is to correct I2C bus in H2/Lager board (revise to IIC3 from I2C3). In M2/Koelsch board, name of IICDVFS is I2C6. > > Khiem-san, in the future please CC Wolfram about issues related to I2C. I got it. Thanks. > > / magnus > -- Best regards, KHIEM Nguyen