From mboxrd@z Thu Jan  1 00:00:00 1970
From: =?ISO-8859-15?Q?Christian_K=F6nig?= <deathsimple@vodafone.de>
Subject: Re: [PATCH] drm/radeon: Inline r100_mm_rreg, -wreg, v3
Date: Thu, 10 Jul 2014 10:55:03 +0200
Message-ID: <53BE54E7.6020905@vodafone.de>
References: <20140420202933.78b3e355.cand@gmx.com>	<535406B7.3090309@vodafone.de>
 <20140710114831.a89f9c83.cand@gmx.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="iso-8859-15"; Format="flowed"
Content-Transfer-Encoding: quoted-printable
Return-path: <dri-devel-bounces@lists.freedesktop.org>
Received: from pegasos-out.vodafone.de (pegasos-out.vodafone.de [80.84.1.38])
 by gabe.freedesktop.org (Postfix) with ESMTP id 796D16E043
 for <dri-devel@lists.freedesktop.org>; Thu, 10 Jul 2014 01:55:17 -0700 (PDT)
In-Reply-To: <20140710114831.a89f9c83.cand@gmx.com>
List-Unsubscribe: <http://lists.freedesktop.org/mailman/options/dri-devel>,
 <mailto:dri-devel-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <http://lists.freedesktop.org/archives/dri-devel>
List-Post: <mailto:dri-devel@lists.freedesktop.org>
List-Help: <mailto:dri-devel-request@lists.freedesktop.org?subject=help>
List-Subscribe: <http://lists.freedesktop.org/mailman/listinfo/dri-devel>,
 <mailto:dri-devel-request@lists.freedesktop.org?subject=subscribe>
Errors-To: dri-devel-bounces@lists.freedesktop.org
Sender: "dri-devel" <dri-devel-bounces@lists.freedesktop.org>
To: Lauri Kasanen <cand@gmx.com>
Cc: Alex Deucher <alexander.deucher@amd.com>, dri-devel@lists.freedesktop.org
List-Id: dri-devel@lists.freedesktop.org

Am 10.07.2014 10:48, schrieb Lauri Kasanen:
> On Sun, 20 Apr 2014 19:41:11 +0200
> Christian K=F6nig <deathsimple@vodafone.de> wrote:
>
>> Am 20.04.2014 19:29, schrieb Lauri Kasanen:
>>> This was originally un-inlined by Andi Kleen in 2011 citing size concer=
ns.
>>> Indeed, a first attempt at inlining it grew radeon.ko by 7%.
>>>
>>> However, 2% of cpu is spent in this function. Simply inlining it gave 1=
% more fps
>>> in Urban Terror.
>>>
>>> v2: We know the minimum MMIO size. Adding it to the if allows the compi=
ler to
>>> optimize the branch out, improving both performance and size.
>>>
>>> The v2 patch decreases radeon.ko size by 2%. I didn't re-benchmark, but=
 common sense
>>> says perf is now more than 1% better.
>>>
>>> v3: Also change _wreg, make the threshold a define.
>>>
>>> Inlining _wreg increased the size a bit compared to v2, so now radeon.ko
>>> is only 1% smaller.
>>>
>>> Signed-off-by: Lauri Kasanen <cand@gmx.com>
>> Reviewed-by: Christian K=F6nig <christian.koenig@amd.com>
> Ping. Although reviewed in April, seems this wasn't applied to any tree?

Sorry looks like I missed it. Alex can you pull that in your 3.17 branch?

Thanks,
Christian.

>
> - Lauri