From mboxrd@z Thu Jan  1 00:00:00 1970
From: Julien Grall <julien.grall@linaro.org>
Subject: Re: [Linaro-uefi] [PATCH RFC 19/19] Add EFI stub for
	ARM64
Date: Thu, 10 Jul 2014 10:21:38 +0100
Message-ID: <53BE5B22.60804@linaro.org>
References: <1403918735-30027-1-git-send-email-roy.franz@linaro.org>
	<1403918735-30027-20-git-send-email-roy.franz@linaro.org>
	<1404304461.5562.58.camel@kazak.uk.xensource.com>
	<CAFECyb-W=2+5_pJtYMWqcRVQPV0Z+SUoTUmiN54tuoRE5KeHJg@mail.gmail.com>
	<1404979994.11981.23.camel@dagon.hellion.org.uk>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"; Format="flowed"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <1404979994.11981.23.camel@dagon.hellion.org.uk>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Ian Campbell <Ian.Campbell@citrix.com>, Roy Franz <roy.franz@linaro.org>
Cc: keir <keir@xen.org>, tim <tim@xen.org>, xen-devel <xen-devel@lists.xen.org>, Stefano Stabellini <stefano.stabellini@citrix.com>, Jan Beulich <jbeulich@suse.com>, linaro-uefi <linaro-uefi@lists.linaro.org>
List-Id: xen-devel@lists.xenproject.org

Hi Ian & Roy,

On 10/07/14 09:13, Ian Campbell wrote:
>>> Probably the easiest thing to do there is to create
>>> xen/arch/arm/efi/stub.c and do the fshort-char trick for that entire
>>> folder, since I don't think our build system makes it especially easy to
>>> change CFLAGS for individual object files.
>>
>> Yes and yes.  I will likely end up with some single file directories due to the
>> build option differences.  Is there a XEN build system expert that I can ask
>> for help if needed?  (Or should I just post to the list?)
>
> I'm not sure anyone is an expert on this stuff but feel free to prod me
> either here or on #xenarm.
>
> I think you just need something like, in xen/arch/arm/Makefile
>     subdir-$(arm64) += efi # or CONFIG_EFI etc
> and in xen/arch/arm/efi/Makefile:
>     CFLAGS += -fshort-wchar
>     obj-y += foo.o etc.o
>
> much the same for xen/common/efi.

The Xen buildsystem doesn't provide CFLAGS facilities as the Kernel, but 
the Makefile has a syntax to append data in variables for a specific target.

If your efi.c is in xen/arch/arm/, you need to add in xen/arch/arm/Makefile:

efi.o: CFLAGS += -fshort-wchar

Regards,

-- 
Julien Grall