From mboxrd@z Thu Jan 1 00:00:00 1970 From: Khiem Nguyen Date: Thu, 10 Jul 2014 10:01:38 +0000 Subject: Re: [PATCH v2] ARM: shmobile: Lager: Correct I2C bus for VDD MPU regulator Message-Id: <53BE6482.80505@renesas.com> List-Id: References: <53B5F327.5040301@renesas.com> In-Reply-To: <53B5F327.5040301@renesas.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: linux-sh@vger.kernel.org On 7/10/2014 6:46 PM, Magnus Damm wrote: > Hi Wolfram, Khiem-san, everyone, > > On Thu, Jul 10, 2014 at 11:40 AM, Wolfram Sang wrote: >> >>> Wolfram, can you give us your opinion about this patch? Does it >>> improve our I2C software support on Lager? >> >> Yes, it does. Khiem-san is right, IIC3 is dedicated to DVFS, so it >> should be activated. From that point of view: >> >> Reviewed-by: Wolfram Sang > > Good - thanks for confirming! @Wolfram-san: Thanks for your review. @Magnus-san, Simon-san: Then, is it OK to merge this patch ? > >> However, I sadly missed commit e489c2a9bc82713167d9f721ca764f4b0d37e543 >> ("ARM: shmobile: lager: enable i2c devices") which enables i2c cores for >> all busses. I do like the iic cores better because of SMBUS_QUICK >> support and DMA capability (although not yet supported). i2c cores have >> slave support as an advantage, yet they can be switched in when that is >> actually needed (still needs to be implemented, too). So, it might make >> sense to switch all busses to iic, I'd say. > > Yes, I agree about your observation. If you have time, can you cook up > a patch to improve the situation? > > Best, > > / magnus > -- Best regards, KHIEM Nguyen