From: Julien Grall <julien.grall@linaro.org>
To: Ian Campbell <ian.campbell@citrix.com>
Cc: stefano.stabellini@eu.citrix.com, tim@xen.org, xen-devel@lists.xen.org
Subject: Re: [PATCH v5 7/8] xen: arm: use superpages in p2m when pages are suitably aligned
Date: Thu, 10 Jul 2014 11:36:09 +0100 [thread overview]
Message-ID: <53BE6C99.9070806@linaro.org> (raw)
In-Reply-To: <1404925873.26217.13.camel@hastur.hellion.org.uk>
On 09/07/14 18:11, Ian Campbell wrote:
> On Wed, 2014-07-09 at 17:28 +0100, Julien Grall wrote:
>>> + /*
>>> + * could flush up to the next boundary, but would need to be
>>> + * careful about preemption, so just do one page now and loop.
>>
>> At the first glance I though this code didn't handle correctly superpage
>> flush. It took me several minutes to understand that you rely
>> P2M_ONE_PROGRESS{,_NOP} to do the job for you.
>>
>> Can you explain this trick in the commit message?
>
> That's what the existing comment which you've quoted is attempting to
> explain. Is it not clear enough? Can you suggest an improvement?
>
> Would "up to the next superpage boundary ... do one 4K page now and
> loop" suffice?
I think the most confusing word is "loop". I was waiting for see a
"real" loop below.
I would explain that the outer function taking care of the loop.
Regards,
--
Julien Grall
next prev parent reply other threads:[~2014-07-10 10:36 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-09 12:06 [PATCH v5 0/8] xen: arm: Use super pages in p2m Ian Campbell
2014-07-09 12:07 ` [PATCH v5 1/8] xen: arm: dump vcpu gic info in arch_dump_vcpu_info Ian Campbell
2014-07-09 12:07 ` [PATCH v5 2/8] tools/libxc: pull min/max_t into xc_private.h Ian Campbell
2014-07-10 11:01 ` Ian Jackson
2014-07-10 11:08 ` Ian Campbell
2014-07-09 12:07 ` [PATCH v5 3/8] tools: arm: allocate large pages to guests Ian Campbell
2014-07-09 15:19 ` Ian Jackson
2014-07-09 12:07 ` [PATCH v5 4/8] xen: arm: only put_page for p2m operations which require it Ian Campbell
2014-07-09 12:07 ` [PATCH v5 5/8] xen: arm: handle superpage mappings in p2m_lookup Ian Campbell
2014-07-09 12:07 ` [PATCH v5 6/8] xen: arm: add some helpers for assessing p2m pte Ian Campbell
2014-07-09 12:07 ` [PATCH v5 7/8] xen: arm: use superpages in p2m when pages are suitably aligned Ian Campbell
2014-07-09 16:28 ` Julien Grall
2014-07-09 17:11 ` Ian Campbell
2014-07-10 10:36 ` Julien Grall [this message]
2014-07-10 11:17 ` Ian Campbell
2014-07-10 12:44 ` Julien Grall
2014-07-10 15:22 ` Ian Campbell
2014-07-09 12:07 ` [PATCH v5 8/8] xen: arm: allocate more than one bank for 1:1 domain 0 if needed Ian Campbell
2014-07-09 16:40 ` Julien Grall
2014-07-10 10:32 ` [PATCH v5 0/8] xen: arm: Use super pages in p2m Ian Campbell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53BE6C99.9070806@linaro.org \
--to=julien.grall@linaro.org \
--cc=ian.campbell@citrix.com \
--cc=stefano.stabellini@eu.citrix.com \
--cc=tim@xen.org \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.