From: "Srivatsa S. Bhat" <srivatsa@MIT.EDU>
To: Viresh Kumar <viresh.kumar@linaro.org>
Cc: "Rafael J. Wysocki" <rjw@rjwysocki.net>,
Lists linaro-kernel <linaro-kernel@lists.linaro.org>,
"linux-pm@vger.kernel.org" <linux-pm@vger.kernel.org>,
Arvind Chauhan <arvind.chauhan@arm.com>,
Saravana Kannan <skannan@codeaurora.org>,
"Bu, Yitian" <ybu@qti.qualcomm.com>,
Stable <stable@vger.kernel.org>
Subject: Re: [PATCH] cpufreq: move policy kobj to policy->cpu at resume
Date: Thu, 10 Jul 2014 16:52:18 +0530 [thread overview]
Message-ID: <53BE776A.6060401@mit.edu> (raw)
In-Reply-To: <CAKohpokb3S3czYB46JsDYggYBYi34CmRhjNGVJDO3wtLV7xGzQ@mail.gmail.com>
On 07/10/2014 04:50 PM, Viresh Kumar wrote:
> On 10 July 2014 16:45, Srivatsa S. Bhat <srivatsa@mit.edu> wrote:
>> Looks good to me. But I think it would be better to move the invocation of
>> kobject_move() to update_policy_cpu() itself, so that update_policy_cpu()
>> will do all the work involved in updating the policy->cpu, as its name suggests.
>
> Its called from remove path as well ..
>
I know.. That's why it makes even more sense to consolidate all the
work into one function. We can restructure cpufreq_nominate_new_policy_cpu()
such that the kobject_move() can be moved to update_policy_cpu().
Regards,
Srivatsa S. Bhat
next prev parent reply other threads:[~2014-07-10 11:22 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-10 5:19 [PATCH] cpufreq: move policy kobj to policy->cpu at resume Viresh Kumar
2014-07-10 7:08 ` Bu, Yitian
2014-07-10 7:10 ` Viresh Kumar
2014-07-10 7:13 ` Bu, Yitian
2014-07-10 11:15 ` Srivatsa S. Bhat
2014-07-10 11:20 ` Viresh Kumar
2014-07-10 11:22 ` Srivatsa S. Bhat [this message]
2014-07-10 12:42 ` Viresh Kumar
2014-07-11 6:01 ` Viresh Kumar
-- strict thread matches above, loose matches on Subject: below --
2014-08-01 10:25 Viresh Kumar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53BE776A.6060401@mit.edu \
--to=srivatsa@mit.edu \
--cc=arvind.chauhan@arm.com \
--cc=linaro-kernel@lists.linaro.org \
--cc=linux-pm@vger.kernel.org \
--cc=rjw@rjwysocki.net \
--cc=skannan@codeaurora.org \
--cc=stable@vger.kernel.org \
--cc=viresh.kumar@linaro.org \
--cc=ybu@qti.qualcomm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.