From mboxrd@z Thu Jan 1 00:00:00 1970 From: Razvan Cojocaru Subject: Re: [PATCH RFC 2/9] xen: Optimize introspection access to guest state Date: Thu, 10 Jul 2014 15:16:35 +0300 Message-ID: <53BE8423.4070101@bitdefender.com> References: <1404308041-15461-1-git-send-email-rcojocaru@bitdefender.com> <1404308041-15461-2-git-send-email-rcojocaru@bitdefender.com> <53B425B4.3010808@citrix.com> <53BE4963.1070904@bitdefender.com> <53BE4C36.4000805@citrix.com> <53BE7FC5.8060907@bitdefender.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <53BE7FC5.8060907@bitdefender.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Andrew Cooper , xen-devel@lists.xen.org Cc: tim@xen.org List-Id: xen-devel@lists.xenproject.org On 07/10/2014 02:57 PM, Razvan Cojocaru wrote: > So this solution would appear to be a bit more involved than the initial > solution. But you're, of course, right that guest_x86_mode should not be > VMX-specific. > > Would it be OK if I would replace the call to vmx_guest_x86_mode() to a > call to hvm_funcs.guest_x86_mode(v) (assuming that's possible)? Actually, I probably misunderstood this, since "c->guest_x86_mode = vmx_guest_x86_mode(v);" only happens in vmx.c, and p2m.c does "req->regs.guest_x86_mode = hvm_guest_x86_mode(current);". So I think extending this to SVM would simply require a change similar to the one in vmx.c in svm.c (presumably in svm_vmcb_save(), with the help of svm_guest_x86_mode()). How does this tie any SVM extension of our work to VT-x internals? Thanks, Razvan Cojocaru