From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by mail.openembedded.org (Postfix) with ESMTP id B7436702AB for ; Thu, 10 Jul 2014 13:50:25 +0000 (UTC) Received: from orsmga002.jf.intel.com ([10.7.209.21]) by orsmga102.jf.intel.com with ESMTP; 10 Jul 2014 06:44:53 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.01,637,1400050800"; d="scan'208";a="571141078" Received: from unknown (HELO [10.255.13.46]) ([10.255.13.46]) by orsmga002.jf.intel.com with ESMTP; 10 Jul 2014 06:50:25 -0700 Message-ID: <53BE9A21.8060606@linux.intel.com> Date: Thu, 10 Jul 2014 06:50:25 -0700 From: Saul Wold User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.5.0 MIME-Version: 1.0 To: Roxana Ciobanu , openembedded-core@lists.openembedded.org References: <56d5da369a640da16ac88ce325b12636d17e0400.1404997871.git.roxana.ciobanu@intel.com> In-Reply-To: <56d5da369a640da16ac88ce325b12636d17e0400.1404997871.git.roxana.ciobanu@intel.com> Subject: Re: [PATCH v2 1/1] latencytop: fix mount error X-BeenThere: openembedded-core@lists.openembedded.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: Patches and discussions about the oe-core layer List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 10 Jul 2014 13:50:34 -0000 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit On 07/10/2014 06:13 AM, Roxana Ciobanu wrote: > Bug was fixed by redirecting stderr to /dev/null. The error was > caused because /sys/kernel/debug was already mounted by sysfs.sh. > > [ YOCTO #6498 ] > > Signed-off-by: Roxana Ciobanu > --- > .../latencytop/latencytop-0.5/latencytop-fsync-mount.patch | 13 +++++++++++++ > meta/recipes-kernel/latencytop/latencytop_0.5.bb | 5 +++-- > 2 files changed, 16 insertions(+), 2 deletions(-) > create mode 100644 meta/recipes-kernel/latencytop/latencytop-0.5/latencytop-fsync-mount.patch > > diff --git a/meta/recipes-kernel/latencytop/latencytop-0.5/latencytop-fsync-mount.patch b/meta/recipes-kernel/latencytop/latencytop-0.5/latencytop-fsync-mount.patch > new file mode 100644 > index 0000000..043be75 > --- /dev/null > +++ b/meta/recipes-kernel/latencytop/latencytop-0.5/latencytop-fsync-mount.patch This patch is missing a Signed-off-by: and an Upstream-Status. Have you sent email to the latencytop list? > @@ -0,0 +1,13 @@ > +Index: latencytop-0.5/fsync.c > +=================================================================== > +--- latencytop-0.5.orig/fsync.c > ++++ latencytop-0.5/fsync.c > +@@ -151,7 +151,7 @@ int enable_fsync_tracer(void) > + * echo ftrace_printk > iter_ctrl > + * echo 1 > tracing_on > + */ > +- ret = system("/bin/mount -t debugfs none /sys/kernel/debug/"); > ++ ret = system("/bin/mount -t debugfs none /sys/kernel/debug/ 2>/dev/null"); So this is masking the issue, not addressing it, but this will cause other true errors to be masked. I think Ross's suggestion of using stat() to check for the existance of a file in debugfs would be better. > + if (!ret) > + return -1; > + write_to_file("/sys/kernel/debug/tracing/current_tracer", "fsync"); > diff --git a/meta/recipes-kernel/latencytop/latencytop_0.5.bb b/meta/recipes-kernel/latencytop/latencytop_0.5.bb > index 516e2c5..9a95b92 100644 > --- a/meta/recipes-kernel/latencytop/latencytop_0.5.bb > +++ b/meta/recipes-kernel/latencytop/latencytop_0.5.bb > @@ -6,11 +6,12 @@ LIC_FILES_CHKSUM = "file://latencytop.c;endline=23;md5=ee9ea9b1415356e5734adad4a > > DEPENDS = "virtual/libintl ncurses glib-2.0 ${@bb.utils.contains('DISTRO_FEATURES', 'x11', 'gtk+', '', d)}" > > -PR = "r3" > +PR = "r4" > PR Bumps are not needed any more Sau! > SRC_URI = "http://www.latencytop.org/download/latencytop-${PV}.tar.gz \ > file://latencytop-makefile.patch \ > - file://latencytop-fsync.patch" > + file://latencytop-fsync.patch \ > + file://latencytop-fsync-mount.patch" > > SRC_URI[md5sum] = "73bb3371c6ee0b0e68e25289027e865c" > SRC_URI[sha256sum] = "9e7f72fbea7bd918e71212a1eabaad8488d2c602205d2e3c95d62cd57e9203ef" >