From mboxrd@z Thu Jan 1 00:00:00 1970 From: Julien Grall Subject: Re: [PATCH] xen/arm: Correctly support WARN_ON Date: Thu, 10 Jul 2014 16:07:31 +0100 Message-ID: <53BEAC33.9000501@linaro.org> References: <1404240719-13164-1-git-send-email-julien.grall@linaro.org> <1405004797.26155.19.camel@kazak.uk.xensource.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii"; Format="flowed" Content-Transfer-Encoding: 7bit Return-path: Received: from mail6.bemta5.messagelabs.com ([195.245.231.135]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1X5Fwg-0000v2-2J for xen-devel@lists.xenproject.org; Thu, 10 Jul 2014 15:07:38 +0000 Received: by mail-we0-f169.google.com with SMTP id t60so9194832wes.28 for ; Thu, 10 Jul 2014 08:07:36 -0700 (PDT) In-Reply-To: <1405004797.26155.19.camel@kazak.uk.xensource.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Ian Campbell Cc: xen-devel@lists.xenproject.org, tim@xen.org, stefano.stabellini@citrix.com List-Id: xen-devel@lists.xenproject.org On 10/07/14 16:06, Ian Campbell wrote: > On Tue, 2014-07-01 at 19:51 +0100, Julien Grall wrote: >> Currently the hypervisor will hang if it hits a WARN_ON. >> >> The implemention uses an undefined instruction, made ourself because ARM >> doesn't provide one, to implement BUG/ASSERT/WARN_ON, and sets up the >> different tables (one for each type) which contain useful information. >> >> This is based on the x86 implementation (include/asm-x86/bug.h). Unfortunately >> the structure can't be shared because many ARM{32,64} gcc versions doesn't >> correctly support %c. The support of executing a function in an exception handler >> is also keep unimplemented on ARM. >> >> TODO: >> I haven't yet hook the code on ARM64 as I'm not sure how undefined instruction >> are handled. It looks like there is multiple way to get it via HSR. >> >> Signed-off-by: Julien Grall > > Apart from the lack of arm64 support this looks good to me. I will try to send a new version with the arm64 support next week. Regards, -- Julien Grall