From: Tyrel Datwyler <tyreld@linux.vnet.ibm.com>
To: Michael Ellerman <mpe@ellerman.id.au>
Cc: grant.likely@linaro.org, nfont@linux.vnet.ibm.com,
linuxppc-dev@lists.ozlabs.org
Subject: Re: [PATCH] powerpc/pseries: dynamically added OF nodes need to call of_node_init
Date: Thu, 10 Jul 2014 11:36:04 -0700 [thread overview]
Message-ID: <53BEDD14.10901@linux.vnet.ibm.com> (raw)
In-Reply-To: <1404959630.27178.1.camel@concordia>
On 07/09/2014 07:33 PM, Michael Ellerman wrote:
> On Wed, 2014-07-09 at 21:20 -0400, Tyrel Datwyler wrote:
>> Commit 75b57ecf9 refactored device tree nodes to use kobjects such that they
>> can be exposed via /sysfs. A secondary commit 0829f6d1f furthered this rework
>> by moving the kobect initialization logic out of of_node_add into its own
>> of_node_init function. The inital commit removed the existing kref_init calls
>> in the pseries dlpar code with the assumption kobject initialization would
>> occur in of_node_add. The second commit had the side effect of triggering a
>> BUG_ON as a result of dynamically added nodes being uninitialized.
>
> So does this mean DLPAR is broken since 0829f6d1f (3.15-rc1)?
Yes, as well as suspend and migration.
>
> If so this should have a Cc: stable@kernel.org shouldn't it?
Doh, right you are.
>
> And the latest trend is to also add:
>
> Fixes: 0829f6d1f69e ("of: device_node kobject lifecycle fixes")
Got it. Will resend v2.
-Tyrel
>
> cheers
>
>
> _______________________________________________
> Linuxppc-dev mailing list
> Linuxppc-dev@lists.ozlabs.org
> https://lists.ozlabs.org/listinfo/linuxppc-dev
>
prev parent reply other threads:[~2014-07-10 18:36 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-10 1:20 [PATCH] powerpc/pseries: dynamically added OF nodes need to call of_node_init Tyrel Datwyler
2014-07-10 2:33 ` Michael Ellerman
2014-07-10 13:40 ` Nathan Fontenot
2014-07-10 18:36 ` Tyrel Datwyler [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53BEDD14.10901@linux.vnet.ibm.com \
--to=tyreld@linux.vnet.ibm.com \
--cc=grant.likely@linaro.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mpe@ellerman.id.au \
--cc=nfont@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.