From: "H. Peter Anvin" <hpa@zytor.com>
To: Jan Beulich <JBeulich@suse.com>, mingo@elte.hu, tglx@linutronix.de
Cc: Andy Lutomirski <luto@amacapital.net>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ix86: fix vDSO build
Date: Thu, 10 Jul 2014 15:58:28 -0700 [thread overview]
Message-ID: <53BF1A94.50009@zytor.com> (raw)
In-Reply-To: <53B5863B02000078000204D5@mail.emea.novell.com>
On 07/03/2014 07:35 AM, Jan Beulich wrote:
> Relying on static functions used just once to get inlined (and
> subsequently have dead code paths eliminated) is wrong: Compilers are
> free to decide whether they do this, regardless of optimization level.
> With this not happening for vdso_addr() (observed with gcc 4.1.x), an
> unresolved reference to align_vdso_addr() causes the build to fail.
The fix seems odd... more of the flavor of "happens to work" unless I'm
misunderstanding something. If this needs to be inlined, wouldn't
__always_inline make more sense?
What am I missing?
-hpa
next prev parent reply other threads:[~2014-07-10 22:59 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-03 14:35 [PATCH] ix86: fix vDSO build Jan Beulich
2014-07-03 15:34 ` Andy Lutomirski
2014-07-03 15:44 ` Jan Beulich
2014-07-03 15:51 ` Andy Lutomirski
2014-07-03 23:10 ` Boris Ostrovsky
2014-07-09 23:30 ` Andrew Morton
2014-07-10 22:58 ` H. Peter Anvin [this message]
2014-07-23 8:07 ` Jan Beulich
2014-07-10 23:45 ` [tip:x86/urgent] x86-32, vdso: Fix vDSO build error due to missing align_vdso_addr() tip-bot for Jan Beulich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53BF1A94.50009@zytor.com \
--to=hpa@zytor.com \
--cc=JBeulich@suse.com \
--cc=linux-kernel@vger.kernel.org \
--cc=luto@amacapital.net \
--cc=mingo@elte.hu \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.