Re: [PATCH 2/2] i2c-stub: Add support for banked register ranges

[Guenter Roeck <linux-0h96xk9xTtrk1uMJSBkQmQ@public.gmane.org>]

On 07/10/2014 02:30 PM, Jean Delvare wrote:
> On Thu, 10 Jul 2014 11:40:36 -0700, Guenter Roeck wrote:
>> On Thu, Jul 10, 2014 at 12:56:59PM +0200, Jean Delvare wrote:
>>> Some chips implement banked register ranges. This allows implementing
>>> more registers than the limited 8-bit address space originally allows.
>>> In order to access a register on these chips, you must first select
>>> the proper bank. Add support for this mechanism to the i2c-stub driver
>>> so that such chips can be emulated. All the bank settings are passed
>>> as module parameters.
>>>
>>> Signed-off-by: Jean Delvare <jdelvare-l3A5Bk7waGM@public.gmane.org>
>>> Cc: Guenter Roeck <linux-0h96xk9xTtrk1uMJSBkQmQ@public.gmane.org>
>>> ---
>>> Tested successfully with:
>>> http://jdelvare.nerim.net/devel/lm-sensors/dumps/w83793-for-stub.dump
>>>
>> Also with NCT7802Y.
>>
>> Tested-by: Guenter Roeck <linux-0h96xk9xTtrk1uMJSBkQmQ@public.gmane.org>
>
> Thanks.
>
>> Would it make sense to use devm_ functions for memory allocations ?
>> That would simplify cleanup.
>
> Sure, no objection from me.
>

If it was that simple :-(. We would have to convert the driver to a platform driver
to be able to do that, since the allocations happen from the initialization code,
not from a probe function. Guess we'll have to leave that for another day.

Guenter