All of lore.kernel.org
 help / color / mirror / Atom feed
From: Paolo Bonzini <pbonzini@redhat.com>
To: TAMUKI Shoichi <tamuki@linet.gr.jp>, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] scsi-bus: fix to allow some special SCSI commands
Date: Fri, 11 Jul 2014 11:02:41 +0200	[thread overview]
Message-ID: <53BFA831.5090008@redhat.com> (raw)
In-Reply-To: <201407110853.AA01527@tamuki.linet.gr.jp>

Il 11/07/2014 10:53, TAMUKI Shoichi ha scritto:
> @@ -563,7 +565,8 @@ SCSIRequest *scsi_req_new(SCSIDevice *d, uint32_t tag, uint32_t lun,
>      SCSIRequest *req;
>      SCSICommand cmd;
>
> -    if (scsi_req_parse(&cmd, d, buf) != 0) {
> +    if (scsi_req_parse(&cmd, d, buf,
> +            ((VirtIOSCSIReq *) hba_private)->dev->parent_obj.cdb_size) != 0) {
>          trace_scsi_req_parse_bad(d->id, lun, tag, buf[0]);
>          req = scsi_req_alloc(&reqops_invalid_opcode, d, tag, lun, hba_private);
>      } else {

This function is not called only for virtio-scsi.  You need to add a new 
argument to scsi_req_new, and modify all invocations in hw/scsi.

Thanks,

Paolo

  reply	other threads:[~2014-07-11  9:03 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-07-11  8:53 [Qemu-devel] [PATCH] scsi-bus: fix to allow some special SCSI commands TAMUKI Shoichi
2014-07-11  9:02 ` Paolo Bonzini [this message]
2014-07-12 10:21   ` TAMUKI Shoichi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=53BFA831.5090008@redhat.com \
    --to=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=tamuki@linet.gr.jp \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.