From: David Vrabel <david.vrabel@citrix.com>
To: Ethan Zhao <ethan.zhao@oracle.com>, <bhelgaas@google.com>,
<konrad.wilk@oracle.com>, <boris.ostrovsky@oracle.com>,
<gleb@kernel.org>, <pbonzini@redhat.com>,
<jeffrey.t.kirsher@intel.com>, <jesse.brandeburg@intel.com>,
<bruce.w.allan@intel.com>, <carolyn.wyborny@intel.com>,
<donald.c.skidmore@intel.com>, <gregory.v.rose@intel.com>,
<alexander.h.duyck@intel.com>, <john.ronciak@intel.com>,
<mitch.a.williams@intel.com>, <alex.williamson@redhat.com>
Cc: <linux-pci@vger.kernel.org>, <kvm@vger.kernel.org>,
<linux.nics@intel.com>, <e1000-devel@lists.sourceforge.net>,
<netdev@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<ethan.kernel@gmail.com>, <vaughan.cao@oracle.com>
Subject: Re: [PATCH 1/2 V2] PCI: introduce device assignment interface and refactory related code
Date: Fri, 11 Jul 2014 10:41:18 +0100 [thread overview]
Message-ID: <53BFB13E.1060505@citrix.com> (raw)
In-Reply-To: <1405057961-7234-1-git-send-email-ethan.zhao@oracle.com>
On 11/07/14 06:52, Ethan Zhao wrote:
>
> --- a/drivers/xen/xen-pciback/pci_stub.c
> +++ b/drivers/xen/xen-pciback/pci_stub.c
> @@ -133,7 +133,7 @@ static void pcistub_device_release(struct kref *kref)
> xen_pcibk_config_free_dyn_fields(dev);
> xen_pcibk_config_free_dev(dev);
>
> - dev->dev_flags &= ~PCI_DEV_FLAGS_ASSIGNED;
> + pci_sriov_deassign_device(dev);
> pci_dev_put(dev);
>
> kfree(psdev);
> @@ -404,7 +404,7 @@ static int pcistub_init_device(struct pci_dev *dev)
> dev_dbg(&dev->dev, "reset device\n");
> xen_pcibk_reset_device(dev);
>
> - dev->dev_flags |= PCI_DEV_FLAGS_ASSIGNED;
> + pci_sriov_assign_device(dev);
> return 0;
Xen's PCI passthrough works with all PCI devices not just SR-IOV ones,
so the naming of the helpers isn't correct.
David
next prev parent reply other threads:[~2014-07-11 9:41 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-11 5:52 [PATCH 1/2 V2] PCI: introduce device assignment interface and refactory related code Ethan Zhao
2014-07-11 5:52 ` Ethan Zhao
2014-07-11 5:52 ` [PATCH 2/2 V2] PCI: implement VFs assignment reference counter Ethan Zhao
2014-07-11 5:52 ` Ethan Zhao
2014-07-11 9:41 ` David Vrabel [this message]
2014-07-11 11:13 ` [PATCH 1/2 V2] PCI: introduce device assignment interface and refactory related code Ethan Zhao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53BFB13E.1060505@citrix.com \
--to=david.vrabel@citrix.com \
--cc=alex.williamson@redhat.com \
--cc=alexander.h.duyck@intel.com \
--cc=bhelgaas@google.com \
--cc=boris.ostrovsky@oracle.com \
--cc=bruce.w.allan@intel.com \
--cc=carolyn.wyborny@intel.com \
--cc=donald.c.skidmore@intel.com \
--cc=e1000-devel@lists.sourceforge.net \
--cc=ethan.kernel@gmail.com \
--cc=ethan.zhao@oracle.com \
--cc=gleb@kernel.org \
--cc=gregory.v.rose@intel.com \
--cc=jeffrey.t.kirsher@intel.com \
--cc=jesse.brandeburg@intel.com \
--cc=john.ronciak@intel.com \
--cc=konrad.wilk@oracle.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=linux.nics@intel.com \
--cc=mitch.a.williams@intel.com \
--cc=netdev@vger.kernel.org \
--cc=pbonzini@redhat.com \
--cc=vaughan.cao@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.