From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:42460) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1X5Z9a-0000bK-FR for qemu-devel@nongnu.org; Fri, 11 Jul 2014 07:38:23 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1X5Z9R-0002vC-Cj for qemu-devel@nongnu.org; Fri, 11 Jul 2014 07:38:14 -0400 Received: from e06smtp11.uk.ibm.com ([195.75.94.107]:43308) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1X5Z9R-0002uO-3d for qemu-devel@nongnu.org; Fri, 11 Jul 2014 07:38:05 -0400 Received: from /spool/local by e06smtp11.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Fri, 11 Jul 2014 12:38:03 +0100 Received: from b06cxnps4074.portsmouth.uk.ibm.com (d06relay11.portsmouth.uk.ibm.com [9.149.109.196]) by d06dlp01.portsmouth.uk.ibm.com (Postfix) with ESMTP id 30BAC17D8042 for ; Fri, 11 Jul 2014 12:39:35 +0100 (BST) Received: from d06av05.portsmouth.uk.ibm.com (d06av05.portsmouth.uk.ibm.com [9.149.37.229]) by b06cxnps4074.portsmouth.uk.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id s6BBc0Su25034962 for ; Fri, 11 Jul 2014 11:38:00 GMT Received: from d06av05.portsmouth.uk.ibm.com (localhost [127.0.0.1]) by d06av05.portsmouth.uk.ibm.com (8.14.4/8.14.4/NCO v10.0 AVout) with ESMTP id s6BBc0OW005893 for ; Fri, 11 Jul 2014 05:38:00 -0600 Message-ID: <53BFCC97.8070402@de.ibm.com> Date: Fri, 11 Jul 2014 13:37:59 +0200 From: Christian Borntraeger MIME-Version: 1.0 References: <1405077612-7806-1-git-send-email-stefanha@redhat.com> In-Reply-To: <1405077612-7806-1-git-send-email-stefanha@redhat.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH for-2.1? 0/2] thread-pool: avoid fd usage and fix nested aio_poll() deadlock List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Stefan Hajnoczi , qemu-devel@nongnu.org Cc: Paolo Bonzini On 11/07/14 13:20, Stefan Hajnoczi wrote: > These patches convert thread-pool.c from EventNotifier to QEMUBH. They then > solve the deadlock when nested aio_poll() calls are made. > > Please speak out whether you want this in QEMU 2.1 or not. I'm not aware of > the nested aio_poll() deadlock ever having been reported, so maybe we can defer > to QEMU 2.2. > > Stefan Hajnoczi (2): > thread-pool: avoid per-thread-pool EventNotifier > thread-pool: avoid deadlock in nested aio_poll() calls > > thread-pool.c | 44 +++++++++++++++++++++++++++++++------------- > 1 file changed, 31 insertions(+), 13 deletions(-) > Seems to work ok and saves an fd. I think its still better scheduled for 2.2 Christian