From mboxrd@z Thu Jan 1 00:00:00 1970 From: Oliver Hartkopp Subject: Re: skbuff panic Date: Fri, 11 Jul 2014 09:27:19 -0400 Message-ID: <53BFE637.2030905@hartkopp.net> References: <53B7D63B.2060108@hartkopp.net> <53B8504C.4070808@hartkopp.net> <53B93D45.5090505@hartkopp.net> <53B97598.50400@hartkopp.net> <53B9A5AD.8050403@pengutronix.de> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Return-path: Received: from mo4-p00-ob.smtp.rzone.de ([81.169.146.162]:59254 "EHLO mo4-p00-ob.smtp.rzone.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753543AbaGKN1W (ORCPT ); Fri, 11 Jul 2014 09:27:22 -0400 In-Reply-To: Sender: linux-can-owner@vger.kernel.org List-ID: To: Austin Schuh , Marc Kleine-Budde Cc: linux-can@vger.kernel.org Thanks for testing, Austin! I'll cook a patch for stable to add these settings. Even if we do not know why someone requests obviously all netdev skbs and treats them to be Ethernet/IP packets we should fix it in our code. If we fix it somewhere else it will last one year until some of the is-there-anything-else-than-ethernet-networking guys will break it again. ;-) Best regards, Oliver On 10.07.2014 13:37, Austin Schuh wrote: > On Wed, Jul 9, 2014 at 5:07 PM, Austin Schuh wrote: >> With Oliver's patch, I'm able to get to 60 reboots and counting, so it >> looks like that was the problem. I'll leave it rebooting over night >> to be sure. > > The machine survived 216 reboots with no panics over the night. Thanks Oliver! > > Tested-by: Austin Schuh >