From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by yocto-www.yoctoproject.org (Postfix, from userid 118) id 84A47E00769; Fri, 11 Jul 2014 06:41:45 -0700 (PDT) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on yocto-www.yoctoproject.org X-Spam-Level: X-Spam-Status: No, score=-2.6 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_LOW autolearn=ham version=3.3.1 X-Spam-HAM-Report: * -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% * [score: 0.0000] * -0.7 RCVD_IN_DNSWL_LOW RBL: Sender listed at http://www.dnswl.org/, low * trust * [209.85.220.52 listed in list.dnswl.org] Received: from mail-pa0-f52.google.com (mail-pa0-f52.google.com [209.85.220.52]) by yocto-www.yoctoproject.org (Postfix) with ESMTP id 5F299E00736 for ; Fri, 11 Jul 2014 06:41:39 -0700 (PDT) Received: by mail-pa0-f52.google.com with SMTP id eu11so1486199pac.25 for ; Fri, 11 Jul 2014 06:41:39 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:message-id:date:from:user-agent:mime-version:to :subject:references:in-reply-to:content-type :content-transfer-encoding; bh=OSQdgCgO2ce6dcEMDS2PnjT25pf3STApOxvjymuk0Pw=; b=d04x7FEe0xS1ubX6d0OVqJKVTfGz36ycJRtbVGwX3+3EqQIhQBx4xhabEqaCwOG/+q JOBbOekrafIZ/WeshnZJHWDLYSdvebqBQANJnc1IKQeWsTb/uRPZ3k7SAKLmUjuAPbAz IyDBhmOPdcyqBiNy+CgFinTzj2osz2kDmuc2GxSbTw48P+wsXlNWR66kdlRM1eqjmC/4 YMK+QdC1E3ltmObgfgWA6q78puDPczlMIO+jYHGywj9iBzfGTqJ4CfxwstMPfnXAGWiI njichxNevTUc4SYFMphjkTzN5411mX4HZeIh5PHloLyD6IscaZ1MJcI18g5h8/sEyZ4w wRtQ== X-Gm-Message-State: ALoCoQm4OMJHJdgEdGJQ41IZVnZTceR08kjIPrIkUzt/lsfuMIOqsqr1nL7sCyCP2XzGw0x/10vu X-Received: by 10.66.161.69 with SMTP id xq5mr53530024pab.62.1405086099207; Fri, 11 Jul 2014 06:41:39 -0700 (PDT) Received: from [192.168.1.7] (ip98-165-103-37.ph.ph.cox.net. [98.165.103.37]) by mx.google.com with ESMTPSA id bh9sm3133987pdb.58.2014.07.11.06.41.37 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Fri, 11 Jul 2014 06:41:38 -0700 (PDT) Message-ID: <53BFE98E.6090804@boundarydevices.com> Date: Fri, 11 Jul 2014 06:41:34 -0700 From: Eric Nelson User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.6.0 MIME-Version: 1.0 To: Christoph Settgast , meta-freescale@yoctoproject.org References: <1405081756-24440-1-git-send-email-christoph.settgast@methodpark.de> In-Reply-To: <1405081756-24440-1-git-send-email-christoph.settgast@methodpark.de> X-Enigmail-Version: 1.6 Subject: Re: [meta-fsl-arm-extra][PATCH] u-boot-script-boundary: Use bb vars for overrides X-BeenThere: meta-freescale@yoctoproject.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: Usage and development list for the meta-fsl-* layers List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 11 Jul 2014 13:41:45 -0000 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Thanks Christoph, On 07/11/2014 05:29 AM, Christoph Settgast wrote: > When using bitbake variables, overrides in bbappends are possible. > The embedded shell variables did not allow this. > > Signed-off-by: Christoph Settgast > --- > recipes-bsp/u-boot/u-boot-script-boundary_git.bb | 32 ++++++++-------------- > 1 file changed, 11 insertions(+), 21 deletions(-) > > diff --git a/recipes-bsp/u-boot/u-boot-script-boundary_git.bb b/recipes-bsp/u-boot/u-boot-script-boundary_git.bb > index b39d963..df4b76f 100644 > --- a/recipes-bsp/u-boot/u-boot-script-boundary_git.bb > +++ b/recipes-bsp/u-boot/u-boot-script-boundary_git.bb > @@ -12,35 +12,25 @@ S = "${WORKDIR}/git" > > inherit deploy > > -do_mkimage () { > +BOOTSCRIPT = "${S}/board/boundary/${MACHINE}/6x_bootscript-yocto.txt" > +BOOTSCRIPT_nitrogen6x-lite = "${S}/board/boundary/nit6xlite/6x_bootscript-yocto.txt" > > - boarddir=nitrogen6x; > - if test "${MACHINE}" = "nitrogen6x-lite"; then > - boarddir=nit6xlite; > - fi > +UPGRADESCRIPT = "${S}/board/boundary/${MACHINE}/6x_upgrade.txt" > +UPGRADESCRIPT_nitrogen6x-lite = "${S}/board/boundary/nitrogen6x/6x_upgrade.txt" > > +do_mkimage () { > # allow deploy to use the ${MACHINE} name to simplify things > if [ ! -d board/boundary/${MACHINE} ]; then > mkdir board/boundary/${MACHINE} > fi > - bootscript=board/boundary/${boarddir}/6x_bootscript-yocto.txt; > - if ! [ -f $bootscript ]; then > - bootscript=board/boundary/${boarddir}/6x_bootscript-yocto.txt; > - fi > - echo "bootscript == $bootscript" > - > - upgradescript=board/boundary/${boarddir}/6x_upgrade.txt; > - if ! [ -f $upgradescript ]; then > - upgradescript=board/boundary/nitrogen6x/6x_upgrade.txt; > - fi > > - uboot-mkimage -A arm -O linux -T script -C none -a 0 -e 0 \ > - -n "boot script" -d $bootscript \ > - board/boundary/${MACHINE}/6x_bootscript > + uboot-mkimage -A arm -O linux -T script -C none -a 0 -e 0 \ > + -n "boot script" -d ${BOOTSCRIPT} \ > + board/boundary/${MACHINE}/6x_bootscript > > - uboot-mkimage -A arm -O linux -T script -C none -a 0 -e 0 \ > - -n "upgrade script" -d $upgradescript \ > - board/boundary/${MACHINE}/6x_upgrade > + uboot-mkimage -A arm -O linux -T script -C none -a 0 -e 0 \ > + -n "upgrade script" -d ${UPGRADESCRIPT} \ > + board/boundary/${MACHINE}/6x_upgrade > } > > addtask mkimage after do_compile before do_install > Reviewed-by: Eric Nelson