From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sylwester Nawrocki Subject: Re: [PATCH 1/9] s5p-jpeg: Add support for Exynos3250 SoC Date: Fri, 11 Jul 2014 15:57:12 +0200 Message-ID: <53BFED38.4050207@samsung.com> References: <1404750730-22996-1-git-send-email-j.anaszewski@samsung.com> <1404750730-22996-2-git-send-email-j.anaszewski@samsung.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Return-path: Received: from mailout4.w1.samsung.com ([210.118.77.14]:28139 "EHLO mailout4.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753907AbaGKN5Q (ORCPT ); Fri, 11 Jul 2014 09:57:16 -0400 In-reply-to: <1404750730-22996-2-git-send-email-j.anaszewski@samsung.com> Sender: linux-samsung-soc-owner@vger.kernel.org List-Id: linux-samsung-soc@vger.kernel.org To: Jacek Anaszewski Cc: linux-media@vger.kernel.org, kyungmin.park@samsung.com, b.zolnierkie@samsung.com, linux-samsung-soc@vger.kernel.org On 07/07/14 18:32, Jacek Anaszewski wrote: > +void exynos3250_jpeg_dec_scaling_ratio(void __iomem *regs, > + unsigned int sratio) > +{ > + switch (sratio) { > + case 1: > + sratio = EXYNOS3250_DEC_SCALE_FACTOR_8_8; > + break; > + case 2: > + sratio = EXYNOS3250_DEC_SCALE_FACTOR_4_8; > + break; > + case 4: > + sratio = EXYNOS3250_DEC_SCALE_FACTOR_2_8; > + break; > + case 8: > + sratio = EXYNOS3250_DEC_SCALE_FACTOR_1_8; > + break; > + } Missing the 'default' case ? > + writel(sratio & EXYNOS3250_DEC_SCALE_FACTOR_MASK, > + regs + EXYNOS3250_DEC_SCALING_RATIO); > +} -- Regards, Sylwester