From: Jim Fehlig <jfehlig@suse.com>
To: Ian Campbell <Ian.Campbell@citrix.com>
Cc: "xen.org" <Ian.Jackson@eu.citrix.com>,
Olaf Hering <olaf@aepfle.de>,
xen-devel@lists.xensource.com, keir@xen.org,
stefano.stabellini@eu.citrix.com
Subject: Re: [libvirt bisection] complete build-amd64-libvirt
Date: Fri, 11 Jul 2014 09:06:16 -0600 [thread overview]
Message-ID: <53BFFD68.5090305@suse.com> (raw)
In-Reply-To: <1405086227.27875.8.camel@kazak.uk.xensource.com>
Ian Campbell wrote:
> From 2702cbbffd40384571b39bb6da21d76fc7b8ccd6 Mon Sep 17 00:00:00 2001
> From: Ian Campbell <ian.campbell@citrix.com>
> Date: Fri, 11 Jul 2014 14:38:30 +0100
> Subject: [PATCH] libxl: Correct cast to virDomainDiskDiscard enum.
>
> This was converted to a typedef in 5a2bd4c9171d "conf: more enum
> cleanups in "src/conf/domain_conf.h"" causing:
> libxl/libxl_conf.c: In function 'libxlDiskSetDiscard':
> libxl/libxl_conf.c:724:19: error: conversion to incomplete type
>
> Signed-off-by: Ian Campbell <ian.campbell@citrix.com>
> ---
> src/libxl/libxl_conf.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/src/libxl/libxl_conf.c b/src/libxl/libxl_conf.c
> index 0b4a0b5..f620d47 100644
> --- a/src/libxl/libxl_conf.c
> +++ b/src/libxl/libxl_conf.c
> @@ -721,7 +721,7 @@ libxlDiskSetDiscard(libxl_device_disk *x_disk, int discard)
> if (!x_disk->readwrite)
> return 0;
> #if defined(LIBXL_HAVE_LIBXL_DEVICE_DISK_DISCARD_ENABLE)
> - switch ((enum virDomainDiskDiscard)discard) {
> + switch ((virDomainDiskDiscard)discard) {
> case VIR_DOMAIN_DISK_DISCARD_DEFAULT:
> case VIR_DOMAIN_DISK_DISCARD_LAST:
> break;
>
Thanks for the fix. I've pushed the patch.
Regards,
Jim
next prev parent reply other threads:[~2014-07-11 15:06 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-11 7:06 [libvirt bisection] complete build-amd64-libvirt xen.org
2014-07-11 7:23 ` Olaf Hering
2014-07-11 13:43 ` Ian Campbell
2014-07-11 13:48 ` Olaf Hering
2014-07-11 15:06 ` Jim Fehlig [this message]
-- strict thread matches above, loose matches on Subject: below --
2014-09-26 17:29 xen.org
2015-01-06 1:55 xen.org
2015-01-20 17:20 xen.org
2015-08-16 21:50 osstest service owner
2015-09-28 23:09 osstest service owner
2015-12-16 1:25 osstest service owner
2016-02-03 4:13 osstest service owner
2016-04-11 3:44 osstest service owner
2016-04-17 1:57 osstest service owner
2016-05-21 16:23 osstest service owner
2016-05-28 7:15 osstest service owner
2016-06-15 18:59 osstest service owner
2016-11-03 16:19 osstest service owner
2017-04-28 13:17 osstest service owner
2018-01-13 23:36 osstest service owner
2018-06-07 17:35 osstest service owner
2018-08-18 18:24 osstest service owner
2018-11-19 5:17 osstest service owner
2020-05-23 11:48 osstest service owner
2022-07-21 22:25 osstest service owner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53BFFD68.5090305@suse.com \
--to=jfehlig@suse.com \
--cc=Ian.Campbell@citrix.com \
--cc=Ian.Jackson@eu.citrix.com \
--cc=keir@xen.org \
--cc=olaf@aepfle.de \
--cc=stefano.stabellini@eu.citrix.com \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.