From: Andrew Cooper <andrew.cooper3@citrix.com>
To: Ian Campbell <Ian.Campbell@citrix.com>
Cc: xen-devel@lists.xensource.com, Ian.Jackson@eu.citrix.com,
Stefano Stabellini <stefano.stabellini@eu.citrix.com>
Subject: Re: [PATCH v2] Move xenstore and libxc public headers to include subdir
Date: Fri, 11 Jul 2014 16:29:24 +0100 [thread overview]
Message-ID: <53C002D4.5020901@citrix.com> (raw)
In-Reply-To: <1405092113.32197.2.camel@kazak.uk.xensource.com>
On 11/07/14 16:21, Ian Campbell wrote:
> On Fri, 2014-07-11 at 16:20 +0100, Andrew Cooper wrote:
>
>> Not directly related to your patch but...
>>
>> andrewcoop@andrewcoop:/local/xen.git/tools/qemu-xen-dir-remote$ git grep
>> "xs\.h"
>> configure:#include <xs.h>
>> configure:#include <xs.h>
>> configure:#include <xs.h>
>> configure:#include <xs.h>
>> include/hw/xen/xen_common.h:# include <xs.h>
>>
>> Isn't it time we got code like this off using the legacy xs.h?
> So long as that code also wants to build against older Xen we should
> tolerate them preferring the older headers.
>
>
>
The whole purpose of configure is to try and hide that stuff away.
Surely it should try looking for xenstore.h and, failing that, look for
xs.h and fill in some variable?
We know for certain whether the version of qemu pointed to by xen.git
need the legacy headers still.
~Andrew
next prev parent reply other threads:[~2014-07-11 15:29 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-11 14:48 [PATCH v2] Move xenstore and libxc public headers to include subdir Stefano Stabellini
2014-07-11 15:20 ` Andrew Cooper
2014-07-11 15:21 ` Ian Campbell
2014-07-11 15:29 ` Andrew Cooper [this message]
2014-07-11 15:41 ` Ian Campbell
2014-07-11 17:04 ` Stefano Stabellini
2014-07-11 15:24 ` Ian Campbell
2014-07-11 16:58 ` Stefano Stabellini
2014-07-14 8:58 ` Ian Campbell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53C002D4.5020901@citrix.com \
--to=andrew.cooper3@citrix.com \
--cc=Ian.Campbell@citrix.com \
--cc=Ian.Jackson@eu.citrix.com \
--cc=stefano.stabellini@eu.citrix.com \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.