From: Marc Kleine-Budde <mkl@pengutronix.de>
To: Stefan Agner <stefan@agner.ch>
Cc: wg@grandegger.com, shawn.guo@freescale.com,
kernel@pengutronix.de, linux-arm-kernel@lists.infradead.org,
linux-can@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] can: flexcan: add vf61x support for flexcan
Date: Fri, 11 Jul 2014 19:53:54 +0200 [thread overview]
Message-ID: <53C024B2.60404@pengutronix.de> (raw)
In-Reply-To: <dac76ccd134f41b86f00352d10cfae4b@agner.ch>
[-- Attachment #1: Type: text/plain, Size: 2307 bytes --]
On 07/11/2014 03:58 PM, Stefan Agner wrote:
> Hi Marc,
>
> Am 2014-07-11 14:09, schrieb Marc Kleine-Budde:
>> IMHO it should be 4 seperate patches:
>> - dt
>> - clocks
>> - flexcan_get_berr_counter fixes
>> - your flexcan enhancements
>
> Ok, will split.
>
>>> @@ -362,7 +374,7 @@
>>>
>>> esdhc1: esdhc@400b2000 {
>>> compatible = "fsl,imx53-esdhc";
>>> - reg = <0x400b2000 0x4000>;
>>> + reg = <0x400b2000 0x1000>;
>>
>> What's that doing here? :)
>
> That's an error I just stumbled upon. I know it's not related but it's
> such a small change... Do I need to make a separate patch for that or
> can I include it in the FlexCAN dt commit?
Yes, please post it to Shawn (& linux-arm) directly.
>
>>> @@ -150,18 +171,20 @@
>>> * FLEXCAN hardware feature flags
>>> *
>>> * Below is some version info we got:
>>> - * SOC Version IP-Version Glitch- [TR]WRN_INT
>>> - * Filter? connected?
>>> - * MX25 FlexCAN2 03.00.00.00 no no
>>> - * MX28 FlexCAN2 03.00.04.00 yes yes
>>> - * MX35 FlexCAN2 03.00.00.00 no no
>>> - * MX53 FlexCAN2 03.00.00.00 yes no
>>> - * MX6s FlexCAN3 10.00.12.00 yes yes
>>> + * SOC Version IP-Version Glitch- [TR]WRN_INT Memory err
>>> + * Filter? connected? detection
>>> + * MX25 FlexCAN2 03.00.00.00 no no no
>>> + * MX28 FlexCAN2 03.00.04.00 yes yes no
>>> + * MX35 FlexCAN2 03.00.00.00 no no no
>>> + * MX53 FlexCAN2 03.00.00.00 yes no no
>>> + * MX6s FlexCAN3 10.00.12.00 yes yes no
>>> + * VFxx FlexCAN3 ? no no yes
>>
>> Please use either tabs or space to indent in this table.
>
> Ok, btw, do you know how I can obtain the IP version?
Get in touch with a freescale engineer with VHDL access, meet in a
bar...ask her/him....Something like this :)
Marc
--
Pengutronix e.K. | Marc Kleine-Budde |
Industrial Linux Solutions | Phone: +49-231-2826-924 |
Vertretung West/Dortmund | Fax: +49-5121-206917-5555 |
Amtsgericht Hildesheim, HRA 2686 | http://www.pengutronix.de |
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 242 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: mkl@pengutronix.de (Marc Kleine-Budde)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] can: flexcan: add vf61x support for flexcan
Date: Fri, 11 Jul 2014 19:53:54 +0200 [thread overview]
Message-ID: <53C024B2.60404@pengutronix.de> (raw)
In-Reply-To: <dac76ccd134f41b86f00352d10cfae4b@agner.ch>
On 07/11/2014 03:58 PM, Stefan Agner wrote:
> Hi Marc,
>
> Am 2014-07-11 14:09, schrieb Marc Kleine-Budde:
>> IMHO it should be 4 seperate patches:
>> - dt
>> - clocks
>> - flexcan_get_berr_counter fixes
>> - your flexcan enhancements
>
> Ok, will split.
>
>>> @@ -362,7 +374,7 @@
>>>
>>> esdhc1: esdhc at 400b2000 {
>>> compatible = "fsl,imx53-esdhc";
>>> - reg = <0x400b2000 0x4000>;
>>> + reg = <0x400b2000 0x1000>;
>>
>> What's that doing here? :)
>
> That's an error I just stumbled upon. I know it's not related but it's
> such a small change... Do I need to make a separate patch for that or
> can I include it in the FlexCAN dt commit?
Yes, please post it to Shawn (& linux-arm) directly.
>
>>> @@ -150,18 +171,20 @@
>>> * FLEXCAN hardware feature flags
>>> *
>>> * Below is some version info we got:
>>> - * SOC Version IP-Version Glitch- [TR]WRN_INT
>>> - * Filter? connected?
>>> - * MX25 FlexCAN2 03.00.00.00 no no
>>> - * MX28 FlexCAN2 03.00.04.00 yes yes
>>> - * MX35 FlexCAN2 03.00.00.00 no no
>>> - * MX53 FlexCAN2 03.00.00.00 yes no
>>> - * MX6s FlexCAN3 10.00.12.00 yes yes
>>> + * SOC Version IP-Version Glitch- [TR]WRN_INT Memory err
>>> + * Filter? connected? detection
>>> + * MX25 FlexCAN2 03.00.00.00 no no no
>>> + * MX28 FlexCAN2 03.00.04.00 yes yes no
>>> + * MX35 FlexCAN2 03.00.00.00 no no no
>>> + * MX53 FlexCAN2 03.00.00.00 yes no no
>>> + * MX6s FlexCAN3 10.00.12.00 yes yes no
>>> + * VFxx FlexCAN3 ? no no yes
>>
>> Please use either tabs or space to indent in this table.
>
> Ok, btw, do you know how I can obtain the IP version?
Get in touch with a freescale engineer with VHDL access, meet in a
bar...ask her/him....Something like this :)
Marc
--
Pengutronix e.K. | Marc Kleine-Budde |
Industrial Linux Solutions | Phone: +49-231-2826-924 |
Vertretung West/Dortmund | Fax: +49-5121-206917-5555 |
Amtsgericht Hildesheim, HRA 2686 | http://www.pengutronix.de |
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 242 bytes
Desc: OpenPGP digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20140711/2416b72f/attachment.sig>
next prev parent reply other threads:[~2014-07-11 17:53 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-11 10:52 [PATCH] can: flexcan: add vf61x support for flexcan Stefan Agner
2014-07-11 10:52 ` Stefan Agner
2014-07-11 10:52 ` Stefan Agner
2014-07-11 12:09 ` Marc Kleine-Budde
2014-07-11 12:09 ` Marc Kleine-Budde
2014-07-11 13:58 ` Stefan Agner
2014-07-11 13:58 ` Stefan Agner
2014-07-11 14:00 ` Lucas Stach
2014-07-11 14:00 ` Lucas Stach
2014-07-11 17:53 ` Marc Kleine-Budde [this message]
2014-07-11 17:53 ` Marc Kleine-Budde
2014-07-14 6:04 ` Shawn Guo
2014-07-14 6:04 ` Shawn Guo
2014-07-14 6:04 ` Shawn Guo
2014-07-14 7:06 ` Stefan Agner
2014-07-14 7:06 ` Stefan Agner
2014-07-14 7:10 ` Stefan Agner
2014-07-14 7:10 ` Stefan Agner
2014-07-14 7:32 ` Shawn Guo
2014-07-14 7:32 ` Shawn Guo
2014-07-14 7:32 ` Shawn Guo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53C024B2.60404@pengutronix.de \
--to=mkl@pengutronix.de \
--cc=kernel@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-can@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=shawn.guo@freescale.com \
--cc=stefan@agner.ch \
--cc=wg@grandegger.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.