From: Karsten Blees <karsten.blees@gmail.com>
To: Johannes Sixt <j6t@kdbg.org>
Cc: Stepan Kasal <kasal@ucw.cz>,
Git Mailing List <git@vger.kernel.org>,
msysGit <msysgit@googlegroups.com>
Subject: Re: Topic sk/mingw-unicode-spawn-args breaks tests
Date: Fri, 11 Jul 2014 21:49:15 +0200 [thread overview]
Message-ID: <53C03FBB.1080807@gmail.com> (raw)
In-Reply-To: <53BEF21E.9090007@kdbg.org>
Am 10.07.2014 22:05, schrieb Johannes Sixt:
> It looks like I totally missed the topic sk/mingw-unicode-spawn-args.
> Now it's in master, and it breaks lots of test cases for me:
>
> t0050-filesystem
> t0110-urlmatch-normalization
> t4014-format-patch
> t4041-diff-submodule-option
> t4120-apply-popt
> t4201-shortlog
> t4205-log-pretty-formats
> t4209-log-pickaxe
> t4210-log-i18n
> (I killed the test run here)
>
> Am I doing something wrong? Does the topic depend on a particular
> version of MSYS (or DLL)?
>
> -- Hannes
>
After commenting out fchmod in config.c, I get similar results.
At first glance, t0050 seems to fail because the unicode file
name patches are still missing.
t4041 tries to pass ISO-8859-1 encoded bytes on the command line,
which simply doesn't work on Windows (all OS APIs 'talk' UTF-16).
We have a fix for this in the msysgit fork [1] (but unfortunately
in another branch, so Stepan couldn't know the patch is related).
I suspect the other failures also fall in these two categories.
[1] https://github.com/msysgit/git/commit/ef4a733c
--
--
*** Please reply-to-all at all times ***
*** (do not pretend to know who is subscribed and who is not) ***
*** Please avoid top-posting. ***
The msysGit Wiki is here: https://github.com/msysgit/msysgit/wiki - Github accounts are free.
You received this message because you are subscribed to the Google
Groups "msysGit" group.
To post to this group, send email to msysgit@googlegroups.com
To unsubscribe from this group, send email to
msysgit+unsubscribe@googlegroups.com
For more options, and view previous threads, visit this group at
http://groups.google.com/group/msysgit?hl=en_US?hl=en
---
You received this message because you are subscribed to the Google Groups "msysGit" group.
To unsubscribe from this group and stop receiving emails from it, send an email to msysgit+unsubscribe@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
next prev parent reply other threads:[~2014-07-11 19:49 UTC|newest]
Thread overview: 46+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-10 20:05 Topic sk/mingw-unicode-spawn-args breaks tests Johannes Sixt
2014-07-11 19:49 ` Karsten Blees [this message]
2014-07-12 7:50 ` Stepan Kasal
2014-07-15 0:21 ` Johannes Schindelin
2014-07-15 13:43 ` [PATCH 0/3] fix test suite with mingw-unicode patches Stepan Kasal
2014-07-15 13:43 ` [PATCH 1/3] Win32: Unicode file name support (except dirent) Stepan Kasal
2014-07-15 13:43 ` [PATCH 2/3] Win32: Unicode file name support (dirent) Stepan Kasal
2014-07-15 13:43 ` [PATCH 3/3] tests: do not pass iso8859-1 encoded parameter Stepan Kasal
2014-07-15 13:53 ` [PATCH 0/3] fix test suite with mingw-unicode patches Stepan Kasal
2014-07-15 18:20 ` Junio C Hamano
2014-07-15 22:52 ` Karsten Blees
2014-07-15 22:53 ` [PATCH 1/2] MinGW: fix compile error due to missing ELOOP Karsten Blees
2014-07-15 23:42 ` Jonathan Nieder
2014-07-15 23:57 ` Karsten Blees
2014-07-16 17:43 ` Junio C Hamano
2014-07-15 22:54 ` [PATCH 2/2] config: use chmod() instead of fchmod() Karsten Blees
2014-07-16 5:33 ` Johannes Sixt
2014-07-16 10:53 ` Karsten Blees
2014-07-16 22:16 ` Junio C Hamano
2014-07-17 8:57 ` Karsten Blees
2014-07-16 9:29 ` [PATCH 0/3] fix test suite with mingw-unicode patches Stepan Kasal
2014-07-16 11:01 ` Thomas Braun
2014-07-17 15:36 ` [PATCH 0/6] mingw test fixes Stepan Kasal
2014-07-17 15:37 ` [PATCH 1/6] MinGW: Skip test redirecting to fd 4 Stepan Kasal
2014-07-17 18:41 ` Junio C Hamano
2014-07-17 20:06 ` Johannes Schindelin
2014-07-17 20:18 ` Karsten Blees
2014-07-17 20:38 ` Junio C Hamano
2014-07-17 15:37 ` [PATCH 2/6] Disable t0110's high-bit test on Windows Stepan Kasal
2014-07-17 18:20 ` Karsten Blees
2014-07-18 18:26 ` Junio C Hamano
2014-07-19 19:37 ` [PATCH] t0110/MinGW: skip tests that pass arbitrary bytes on the command line Karsten Blees
2014-07-21 16:41 ` Junio C Hamano
2014-07-17 15:37 ` [PATCH 3/6] MinGW: disable legacy encoding tests Stepan Kasal
2014-07-17 15:37 ` [PATCH 4/6] t4210: skip command-line encoding tests on mingw Stepan Kasal
2014-07-18 9:52 ` Erik Faye-Lund
2014-07-21 16:59 ` Junio C Hamano
2014-07-21 17:45 ` Johannes Schindelin
2014-07-21 19:21 ` Johannes Sixt
2014-07-21 20:07 ` Junio C Hamano
2014-07-21 22:29 ` Junio C Hamano
2014-07-21 22:39 ` Junio C Hamano
2014-07-21 22:30 ` [PATCH 2/2] test prerequisites: enumerate with commas Junio C Hamano
2014-07-17 15:37 ` [PATCH 5/6] t9902: mingw-specific fix for gitfile link files Stepan Kasal
2014-07-17 20:42 ` Junio C Hamano
2014-07-17 15:37 ` [PATCH 6/6] t800[12]: work around MSys limitation Stepan Kasal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53C03FBB.1080807@gmail.com \
--to=karsten.blees@gmail.com \
--cc=git@vger.kernel.org \
--cc=j6t@kdbg.org \
--cc=kasal@ucw.cz \
--cc=msysgit@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.