diff for duplicates of <53C0819E.4000202@cogentembedded.com> diff --git a/a/1.txt b/N1/1.txt index 09f9bb2..26310cb 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -20,8 +20,8 @@ On 07/11/2014 03:54 PM, Lee Jones wrote: > compatible = "st,stih416-b2020", "st,stih416"; > + > + soc { -> + miphy365x_phy: miphy365x at fe382000 { -> + phy_port0: port at fe382000 { +> + miphy365x_phy: miphy365x@fe382000 { +> + phy_port0: port@fe382000 { I don't understand why are you creating the duplicate labels; doesn't 'dtc' complain about them? You could instead refer to them as: @@ -32,7 +32,7 @@ On 07/11/2014 03:54 PM, Lee Jones wrote: > + st,sata-gen = <3>; > + }; > + -> + phy_port1: port at fe38a000 { +> + phy_port1: port@fe38a000 { > + st,pcie-tx-pol-inv; > + }; > + }; @@ -57,7 +57,7 @@ On 07/11/2014 03:54 PM, Lee Jones wrote: > <&softreset STIH416_KEYSCAN_SOFTRESET>; > }; > + -> + miphy365x_phy: miphy365x at fe382000 { +> + miphy365x_phy: miphy365x@fe382000 { The ePAPR standard [1] says: @@ -70,7 +70,7 @@ device and not its precise programming model. > + #size-cells = <1>; > + ranges; > + -> + phy_port0: port at fe382000 { +> + phy_port0: port@fe382000 { > + #phy-cells = <1>; If these are PHY devices, they should be named "phy", not "port". @@ -79,7 +79,7 @@ device and not its precise programming model. > + reg-names = "sata", "pcie", "syscfg"; > + }; > + -> + phy_port1: port at fe38a000 { +> + phy_port1: port@fe38a000 { > + #phy-cells = <1>; > + reg = <0xfe38a000 0x100>, <0xfe804000 0x100>, <0x828 0x4>; > + reg-names = "sata", "pcie", "syscfg"; diff --git a/a/content_digest b/N1/content_digest index 8690a38..68f5686 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -1,10 +1,14 @@ "ref\01404906074-31992-1-git-send-email-lee.jones@linaro.org\0" "ref\01404906074-31992-6-git-send-email-lee.jones@linaro.org\0" "ref\020140711115406.GB2954@lee--X1\0" - "From\0sergei.shtylyov@cogentembedded.com (Sergei Shtylyov)\0" - "Subject\0[PATCH v3+1 5/5] ARM: DT: STi: STiH416: Add DT node for MiPHY365x\0" + "From\0Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>\0" + "Subject\0Re: [PATCH v3+1 5/5] ARM: DT: STi: STiH416: Add DT node for MiPHY365x\0" "Date\0Sat, 12 Jul 2014 04:30:22 +0400\0" - "To\0linux-arm-kernel@lists.infradead.org\0" + "To\0Lee Jones <lee.jones@linaro.org>" + linux-arm-kernel@lists.infradead.org + linux-kernel@vger.kernel.org + " kishon@ti.com\0" + "Cc\0kernel@stlinux.com\0" "\00:1\0" "b\0" "Hello.\n" @@ -29,8 +33,8 @@ "> \tcompatible = \"st,stih416-b2020\", \"st,stih416\";\n" "> +\n" "> +\tsoc {\n" - "> +\t\tmiphy365x_phy: miphy365x at fe382000 {\n" - "> +\t\t\tphy_port0: port at fe382000 {\n" + "> +\t\tmiphy365x_phy: miphy365x@fe382000 {\n" + "> +\t\t\tphy_port0: port@fe382000 {\n" "\n" " I don't understand why are you creating the duplicate labels; doesn't \n" "'dtc' complain about them? You could instead refer to them as:\n" @@ -41,7 +45,7 @@ "> +\t\t\t\tst,sata-gen = <3>;\n" "> +\t\t\t};\n" "> +\n" - "> +\t\t\tphy_port1: port at fe38a000 {\n" + "> +\t\t\tphy_port1: port@fe38a000 {\n" "> +\t\t\t\tst,pcie-tx-pol-inv;\n" "> +\t\t\t};\n" "> +\t\t};\n" @@ -66,7 +70,7 @@ "> \t\t\t\t <&softreset STIH416_KEYSCAN_SOFTRESET>;\n" "> \t\t};\n" "> +\n" - "> +\t\tmiphy365x_phy: miphy365x at fe382000 {\n" + "> +\t\tmiphy365x_phy: miphy365x@fe382000 {\n" "\n" " The ePAPR standard [1] says:\n" "\n" @@ -79,7 +83,7 @@ "> +\t\t\t#size-cells\t= <1>;\n" "> +\t\t\tranges;\n" "> +\n" - "> +\t\t\tphy_port0: port at fe382000 {\n" + "> +\t\t\tphy_port0: port@fe382000 {\n" "> +\t\t\t\t#phy-cells = <1>;\n" "\n" " If these are PHY devices, they should be named \"phy\", not \"port\".\n" @@ -88,7 +92,7 @@ "> +\t\t\t\treg-names = \"sata\", \"pcie\", \"syscfg\";\n" "> +\t\t\t};\n" "> +\n" - "> +\t\t\tphy_port1: port at fe38a000 {\n" + "> +\t\t\tphy_port1: port@fe38a000 {\n" "> +\t\t\t\t#phy-cells = <1>;\n" "> +\t\t\t\treg = <0xfe38a000 0x100>, <0xfe804000 0x100>, <0x828 0x4>;\n" "> +\t\t\t\treg-names = \"sata\", \"pcie\", \"syscfg\";\n" @@ -99,4 +103,4 @@ "\n" WBR, Sergei -0907deb76b97bd9993b1483cb4e016c8d0e81a4ce8167c1826cf625962a5c189 +20f316f54c61f478e5f8cfc394dc476725cb8c9e2859b40e39c8b9d7902db4d1
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.