All of lore.kernel.org
 help / color / mirror / Atom feed
From: Gilles Chanteperdrix <gilles.chanteperdrix@xenomai.org>
To: Jan Kiszka <jan.kiszka@siemens.com>
Cc: Xenomai <xenomai@xenomai.org>
Subject: Re: [Xenomai] Inconsistent traced Linux IRQ state on ARM
Date: Sat, 12 Jul 2014 13:27:56 +0200	[thread overview]
Message-ID: <53C11BBC.6020102@xenomai.org> (raw)
In-Reply-To: <53BF7A2A.7020302@siemens.com>

On 07/11/2014 07:46 AM, Jan Kiszka wrote:
> Gilles,
> 
> we see an warning about an inconsistency of the Linux IRQ state on ARM
> with CONFIG_PROVE_LOCKING and, thus, CONFIG_TRACE_IRQFLAGS. I just
> browsed code and history and stumbled over 11a959bf53 ("ipipe/arm:
> disable calls to trace_hardirqs_(on|off) from assembly", ipipe-3.4.6),
> the only obvious related delta between vanilla and the ipipe kernel. Can
> you comment on both why you disabled it

The reason why I disabled it is that:
1- the spots where these functions are called are spots where hardware
interrupts may be off, but the root stage not necessary stalled, which
will may be confusing;
2- these spots are also deep enough in the assembly code to be called
for real-time tasks, which again may confuse these functions.

Since I do not really understand the need for enabling this option with
CONFIG_IPIPE (if you want to debug some Linux critical sections, you
can do it without CONFIG_IPIPE, if you are after non-virtualized hard
irq flags, the I-pipe tracer has an option to debug them), I simply took
the easy way out and removed these calls.
-- 
                                                                Gilles.


  parent reply	other threads:[~2014-07-12 11:27 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-07-11  5:46 [Xenomai] Inconsistent traced Linux IRQ state on ARM Jan Kiszka
2014-07-11 12:02 ` Gilles Chanteperdrix
2014-07-12 11:27 ` Gilles Chanteperdrix [this message]
2014-07-14  7:01   ` Jan Kiszka
2014-07-14 12:03     ` Gilles Chanteperdrix

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=53C11BBC.6020102@xenomai.org \
    --to=gilles.chanteperdrix@xenomai.org \
    --cc=jan.kiszka@siemens.com \
    --cc=xenomai@xenomai.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.