Re: [PATCH 1/8] iio: accel: bma180: Remove indio_dev->trig assignment

[Jonathan Cameron <jic23@kernel.org>]

On 11/07/14 18:12, Srinivas Pandruvada wrote:
> This can result in wrong reference count for trigger device, leave the binding
> to user space via current_trigger sysfs entry.
> Refer to http://www.spinics.net/lists/linux-iio/msg13669.html for discussion
> with Jonathan.
>
> Signed-off-by: Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>
The issue here is that this is a userspace ABI change.  I'd have love
to not have had these there in the first place, but now they are.
I think a better change would be to simply add a call to iio_trigger_get
in all these cases. That way it's effectively the same as the
> ---
>   drivers/iio/accel/bma180.c | 1 -
>   1 file changed, 1 deletion(-)
>
> diff --git a/drivers/iio/accel/bma180.c b/drivers/iio/accel/bma180.c
> index a7e68c8..1595065 100644
> --- a/drivers/iio/accel/bma180.c
> +++ b/drivers/iio/accel/bma180.c
> @@ -569,7 +569,6 @@ static int bma180_probe(struct i2c_client *client,
>   	trig->ops = &bma180_trigger_ops;
>   	iio_trigger_set_drvdata(trig, indio_dev);
>   	data->trig = trig;
> -	indio_dev->trig = trig;
>
>   	ret = iio_trigger_register(trig);
>   	if (ret)
>