From: Jonathan Cameron <jic23@kernel.org>
To: Marcus Folkesson <marcus.folkesson@gmail.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Sachin Kamat <sachin.kamat@linaro.org>
Cc: linux-iio@vger.kernel.org, devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: iio: adc: ad7192: fix coding style
Date: Sun, 13 Jul 2014 10:11:58 +0100 [thread overview]
Message-ID: <53C24D5E.6070204@kernel.org> (raw)
In-Reply-To: <1405192609-24652-1-git-send-email-marcus.folkesson@gmail.com>
On 12/07/14 20:16, Marcus Folkesson wrote:
> Line over 80 characters. This is for Eudyptula Challenge.
>
> Signed-off-by: Marcus Folkesson <marcus.folkesson@gmail.com>
Sorry Marcus,
There is a level of trivial cleanup below which it's not worth
taking patches. The 80 character limit is not a hard and fast
rule. Here, if this had been picked up during review of the original
patch, or was fixed as a part of a more substantial series, I'd
have no objection taking it. On it's own it's just too small.
Jonathan
> ---
> drivers/staging/iio/adc/ad7192.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/staging/iio/adc/ad7192.c b/drivers/staging/iio/adc/ad7192.c
> index 83bb44b..c25c9ab 100644
> --- a/drivers/staging/iio/adc/ad7192.c
> +++ b/drivers/staging/iio/adc/ad7192.c
> @@ -223,7 +223,8 @@ static int ad7192_setup(struct ad7192_state *st,
> id &= AD7192_ID_MASK;
>
> if (id != st->devid)
> - dev_warn(&st->sd.spi->dev, "device ID query failed (0x%X)\n", id);
> + dev_warn(&st->sd.spi->dev,
> + "device ID query failed (0x%X)\n", id);
>
> switch (pdata->clock_source_sel) {
> case AD7192_CLK_EXT_MCLK1_2:
>
prev parent reply other threads:[~2014-07-13 9:09 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-12 19:16 [PATCH] staging: iio: adc: ad7192: fix coding style Marcus Folkesson
2014-07-13 9:11 ` Jonathan Cameron [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53C24D5E.6070204@kernel.org \
--to=jic23@kernel.org \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marcus.folkesson@gmail.com \
--cc=sachin.kamat@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.