From: Chen Gang <gang.chen.5i5j@gmail.com>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: bergwolf@gmail.com, andreas.dilger@intel.com,
standby24x7@gmail.com, oleg.drokin@intel.com,
Andriy_Skulysh@xyratex.com, denis.pithon@gmail.com, paf@cray.com,
devel@driverdev.osuosl.org,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] drivers: staging: lustre: Use 'force_die' instead of 'die' to avoid compiling issue
Date: Mon, 14 Jul 2014 05:41:56 +0800 [thread overview]
Message-ID: <53C2FD24.5090506@gmail.com> (raw)
In-Reply-To: <20140713190512.GA27311@kroah.com>
On 07/14/2014 03:05 AM, Greg Kroah-Hartman wrote:
> On Sun, Jul 13, 2014 at 10:50:55PM +0800, Chen Gang wrote:
>> Some of architectures have already defined 'die' as macro, so can not use
>> this common name as declaration in other modules, or will cause compiling
>> issue. So use more precise name 'force_die' (like 'wrap_bulk') instead of.
>>
>> The related error (with allmodconfig under score):
>>
>> CC [M] drivers/staging/lustre/lustre/ptlrpc/sec.o
>> drivers/staging/lustre/lustre/ptlrpc/sec.c: In function 'sptlrpc_cli_ctx_expire':
>> drivers/staging/lustre/lustre/ptlrpc/sec.c:309:13: error: 'struct ptlrpc_ctx_ops' has no member named '__die'
>> ctx->cc_ops->die(ctx, 0);
>> ^
>> drivers/staging/lustre/lustre/ptlrpc/sec.c: In function 'ctx_refresh_timeout':
>> drivers/staging/lustre/lustre/ptlrpc/sec.c:594:26: error: 'struct ptlrpc_ctx_ops' has no member named '__die'
>> req->rq_cli_ctx->cc_ops->die(req->rq_cli_ctx, 0);
>> ^
>> make[5]: *** [drivers/staging/lustre/lustre/ptlrpc/sec.o] Error 1
>> make[4]: *** [drivers/staging/lustre/lustre/ptlrpc] Error 2
>> make[3]: *** [drivers/staging/lustre/lustre] Error 2
>> make[2]: *** [drivers/staging/lustre] Error 2
>> make[1]: *** [drivers/staging] Error 2
>> make: *** [drivers] Error 2
>>
>>
>> Signed-off-by: Chen Gang <gang.chen.5i5j@gmail.com>
>> ---
>> drivers/staging/lustre/lustre/include/lustre_sec.h | 2 +-
>> drivers/staging/lustre/lustre/ptlrpc/sec.c | 6 +++---
>> 2 files changed, 4 insertions(+), 4 deletions(-)
>
> This doesn't apply to my tree, can you please refresh it against the
> staging-next branch of staging.git so that I can apply it?
>
OK, I shall go to that tree and send patch for it (I shall finish within
2 days).
Thanks.
--
Chen Gang
Open share and attitude like air water and life which God blessed
next prev parent reply other threads:[~2014-07-13 21:42 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-13 14:50 [PATCH] drivers: staging: lustre: Use 'force_die' instead of 'die' to avoid compiling issue Chen Gang
2014-07-13 19:05 ` Greg Kroah-Hartman
2014-07-13 21:41 ` Chen Gang [this message]
2014-07-13 22:31 ` Chen Gang
2014-07-13 22:38 ` Chen Gang
2014-07-13 22:50 ` Greg Kroah-Hartman
2014-07-13 23:23 ` Chen Gang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53C2FD24.5090506@gmail.com \
--to=gang.chen.5i5j@gmail.com \
--cc=Andriy_Skulysh@xyratex.com \
--cc=andreas.dilger@intel.com \
--cc=bergwolf@gmail.com \
--cc=denis.pithon@gmail.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=oleg.drokin@intel.com \
--cc=paf@cray.com \
--cc=standby24x7@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.