From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:46837) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1X6Wm7-0001Ek-Mt for qemu-devel@nongnu.org; Sun, 13 Jul 2014 23:18:05 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1X6Wm1-00032z-2b for qemu-devel@nongnu.org; Sun, 13 Jul 2014 23:17:59 -0400 Received: from mail-pd0-f180.google.com ([209.85.192.180]:57284) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1X6Wm0-00032J-UJ for qemu-devel@nongnu.org; Sun, 13 Jul 2014 23:17:53 -0400 Received: by mail-pd0-f180.google.com with SMTP id y13so2194894pdi.39 for ; Sun, 13 Jul 2014 20:17:52 -0700 (PDT) Message-ID: <53C34BD9.1040001@ozlabs.ru> Date: Mon, 14 Jul 2014 13:17:45 +1000 From: Alexey Kardashevskiy MIME-Version: 1.0 References: <1402630619-4408-1-git-send-email-aik@ozlabs.ru> <1402630619-4408-4-git-send-email-aik@ozlabs.ru> <20140613080011.7048ce6c.cornelia.huck@de.ibm.com> <539BB66E.10408@ozlabs.ru> <20140616091606.2343cc08.cornelia.huck@de.ibm.com> <539EABC2.2010307@ozlabs.ru> <539EACBC.6060705@suse.de> <53A82C8A.4020908@ozlabs.ru> <53B4E31F.1040801@ozlabs.ru> <87ha2yudb1.fsf@blackfin.pond.sub.org> In-Reply-To: <87ha2yudb1.fsf@blackfin.pond.sub.org> Content-Type: text/plain; charset=KOI8-R Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v7 3/4] s390x: Migrate to new NMI interface List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Markus Armbruster Cc: Peter Maydell , qemu-devel@nongnu.org, Alexander Graf , Luiz Capitulino , Christian Borntraeger , qemu-ppc@nongnu.org, Cornelia Huck , Paolo Bonzini , Richard Henderson On 07/03/2014 05:11 PM, Markus Armbruster wrote: > Alexey Kardashevskiy writes: > >> On 06/23/2014 11:32 PM, Alexey Kardashevskiy wrote: >>> On 06/16/2014 06:37 PM, Alexander Graf wrote: >>>> >>>> On 16.06.14 10:33, Alexey Kardashevskiy wrote: >>>>> On 06/16/2014 05:16 PM, Cornelia Huck wrote: >>>>>> On Sat, 14 Jun 2014 12:41:50 +1000 >>>>>> Alexey Kardashevskiy wrote: >>>>>> >>>>>>> On 06/13/2014 04:00 PM, Cornelia Huck wrote: >>>>>>>> On Fri, 13 Jun 2014 13:36:58 +1000 >>>>>>>> Alexey Kardashevskiy wrote: >>>>>>>> >>>>>>>>> This implements an NMI interface for s390 and s390-ccw machines. >>>>>>>>> >>>>>>>>> This removes #ifdef s390 branch in qmp_inject_nmi so new s390's >>>>>>>>> nmi_monitor_handler() callback is going to be used for NMI. >>>>>>>>> >>>>>>>>> Since nmi_monitor_handler()-calling code is platform independent, >>>>>>>>> CPUState::cpu_index is used instead of S390CPU::env.cpu_num. >>>>>>>>> There should not be any change in behaviour as both @cpu_index and >>>>>>>>> @cpu_num are global CPU numbers. >>>>>>>>> >>>>>>>>> Also, s390_cpu_restart() takes care of preforming operations in >>>>>>>>> the specific CPU thread so no extra measure is required here either. >>>>>>>> I find this paragraph a bit confusing; I'd just remove it. >>>>>>> Besides bad english (please feel free to adjust it), what else is >>>>>>> confusing >>>>>>> here? I put it there because the spapr patch makes use of >>>>>>> async_run_on_cpu() and maintainers may ask why I do not do the same for >>>>>>> other platforms. This way I hoped I could reduce number of versions to >>>>>>> post :) >>>>>> What about >>>>>> >>>>>> "Note that s390_cpu_restart() already takes care of the specified cpu, >>>>>> so we don't need to schedule via async_run_on_cpu()." >>>>> I fail to see how exactly this is better or different but ok :) >>>>> >>>>> >>>>> Alex, should I repost it with Cornelia's suggestion? What should happen >>>>> next to this patchset? Who is supposed to pick it up? Thanks. >>>> >>>> Just post v8 of that single patch with the right message-id as reference. I >>>> can pick up the patches, but I'd like at least an ack from Paolo on the >>>> whole set. >>> >>> >>> Anybody, ping? Or we are waiting till x86 machines got QOM'ed and then I'll >>> repost it with x86 NMI handler? Thanks! >> >> >> Paolo promised to ack (in irc) and obviously forgot :) Should I give up and >> stop bothering noble people? :) > > No, you should politely bother them again. That does not seem helping though :-/ -- Alexey