From mboxrd@z Thu Jan 1 00:00:00 1970 From: =?UTF-8?B?TWljaGVsIETDpG56ZXI=?= Subject: Re: [PATCH 02/83] drm/radeon: reduce number of free VMIDs and pipes in KV Date: Mon, 14 Jul 2014 16:31:59 +0900 Message-ID: <53C3876F.2080103@daenzer.net> References: <1405029027-6085-1-git-send-email-oded.gabbay@amd.com> <20140711160516.GC1870@gmail.com> <53C00E6E.4040908@amd.com> <53C0F921.2030909@amd.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail.gna.ch (darkcity.gna.ch [195.226.6.51]) by gabe.freedesktop.org (Postfix) with ESMTP id 717FC6E3F7 for ; Mon, 14 Jul 2014 00:32:07 -0700 (PDT) In-Reply-To: <53C0F921.2030909@amd.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: =?UTF-8?B?Q2hyaXN0aWFuIEvDtm5pZw==?= Cc: Oded Gabbay , Andrew Lewycky , LKML , Maling list - DRI developers List-Id: dri-devel@lists.freedesktop.org T24gMTIuMDcuMjAxNCAxODowMCwgQ2hyaXN0aWFuIEvDtm5pZyB3cm90ZToKPiBBbSAxMS4wNy4y MDE0IDE4OjIyLCBzY2hyaWViIEFsZXggRGV1Y2hlcjoKPj4gT24gRnJpLCBKdWwgMTEsIDIwMTQg YXQgMTI6MTggUE0sIENocmlzdGlhbiBLw7ZuaWcKPj4gPGNocmlzdGlhbi5rb2VuaWdAYW1kLmNv bT4gd3JvdGU6Cj4+PiBBbSAxMS4wNy4yMDE0IDE4OjA1LCBzY2hyaWViIEplcm9tZSBHbGlzc2U6 Cj4+Pgo+Pj4+IE9uIEZyaSwgSnVsIDExLCAyMDE0IGF0IDEyOjUwOjAyQU0gKzAzMDAsIE9kZWQg R2FiYmF5IHdyb3RlOgo+Pj4+PiBUbyBzdXBwb3J0IEhTQSBvbiBLViwgd2UgbmVlZCB0byBsaW1p dCB0aGUgbnVtYmVyIG9mIHZtaWRzIGFuZCBwaXBlcwo+Pj4+PiB0aGF0IGFyZSBhdmFpbGFibGUg Zm9yIHJhZGVvbidzIHVzZSB3aXRoIEtWLgo+Pj4+Pgo+Pj4+PiBUaGlzIHBhdGNoIHJlc2VydmVz IFZNSURzIDgtMTUgZm9yIEtGRCAoc28gcmFkZW9uIGNhbiBvbmx5IHVzZSBWTUlEcwo+Pj4+PiAw LTcpIGFuZCBhbHNvIG1ha2VzIHJhZGVvbiB0aGlua3MgdGhhdCBLViBoYXMgb25seSBhIHNpbmds ZSBNRUMgd2l0aCBhCj4+Pj4+IHNpbmdsZQo+Pj4+PiBwaXBlIGluIGl0Cj4+Pj4+Cj4+Pj4+IFNp Z25lZC1vZmYtYnk6IE9kZWQgR2FiYmF5IDxvZGVkLmdhYmJheUBhbWQuY29tPgo+Pj4+IFJldmll d2VkLWJ5OiBKw6lyw7RtZSBHbGlzc2UgPGpnbGlzc2VAcmVkaGF0LmNvbT4KPj4+Cj4+PiBBdCBs ZWFzdCBmcm8gdGhlIFZNSURzIG9uIGRlbWFuZCBhbGxvY2F0aW9uIHNob3VsZCBiZSB0cml2aWFs IHRvCj4+PiBpbXBsZW1lbnQsCj4+PiBzbyBJIHdvdWxkIHJhdGhlciBwcmVmZXIgdGhpcyBpbnN0 ZWFkIG9mIGEgZml4ZWQgYXNzaWdubWVudC4KPj4gSUlSQywgdGhlIHdheSB0aGUgQ1AgaHcgc2No ZWR1bGVyIHdvcmtzIHlvdSBoYXZlIHRvIGdpdmUgaXQgYSByYW5nZSBvZgo+PiB2bWlkcyBhbmQg aXQgYXNzaWducyB0aGVtIGR5bmFtaWNhbGx5IGFzIHF1ZXVlcyBhcmUgbWFwcGVkIHNvCj4+IGVm ZmVjdGl2ZWx5IHRoZXkgYXJlIHBvdGVudGlhbGx5IGluIHVzZSBvbmNlIHRoZSBDUCBzY2hlZHVs ZXIgaXMgc2V0Cj4+IHVwLgo+IAo+IFRoYXQncyBub3Qgd2hhdCBJIG1lYW50LiBDaGFuZ2luZyBp dCBjb21wbGV0ZWx5IG9uIHRoZSBmbHkgaXMgbmljZSB0bwo+IGhhdmUsIGJ1dCB3ZSBzaG91bGQg YXQgbGVhc3QgbWFrZSBpdCBjb25maWd1cmFibGUgYXMgYSBtb2R1bGUgcGFyYW1ldGVyLgo+IAo+ IEFuZCBldmVuIGlmIHdlIGhhcmRjb2RlIGl0IHdlIHNob3VsZCB1c2UgYSBkZWZpbmUgZm9yIGl0 IHNvbWV3aGVyZQo+IGluc3RlYWQgb2YgaGFyZGNvZGluZyA4IFZNSURzIG9uIHRoZSBLR0Qgc2lk ZSBhbmQgOCBWTUlEcyBvbiBLRkQgc2lkZQo+IHdpdGhvdXQgYW55IHJlbGF0aW9uIHRvIGVhY2gg b3RoZXIuCgpTZWNvbmRlZCwgYW5kIHRoZXJlIHNob3VsZCBiZSBtb3JlIGV4cGxhbmF0aW9uIGFu ZCByYXRpb25hbGUgZm9yIHRoZSB3YXkKdGhpbmdzIGFyZSBzZXQgdXAgaW4gdGhlIGNvZGUgb3Ig YXQgbGVhc3QgaW4gdGhlIGNvbW1pdCBsb2cuCgoKLS0gCkVhcnRobGluZyBNaWNoZWwgRMOkbnpl ciAgICAgICAgICAgIHwgICAgICAgICAgICAgICAgICBodHRwOi8vd3d3LmFtZC5jb20KTGlicmUg c29mdHdhcmUgZW50aHVzaWFzdCAgICAgICAgICB8ICAgICAgICAgICAgICAgIE1lc2EgYW5kIFgg ZGV2ZWxvcGVyCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f CmRyaS1kZXZlbCBtYWlsaW5nIGxpc3QKZHJpLWRldmVsQGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpo dHRwOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVsCg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753487AbaGNHji (ORCPT ); Mon, 14 Jul 2014 03:39:38 -0400 Received: from darkcity.gna.ch ([195.226.6.51]:42599 "EHLO mail.gna.ch" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752490AbaGNHjc (ORCPT ); Mon, 14 Jul 2014 03:39:32 -0400 Message-ID: <53C3876F.2080103@daenzer.net> Date: Mon, 14 Jul 2014 16:31:59 +0900 From: =?UTF-8?B?TWljaGVsIETDpG56ZXI=?= User-Agent: Mozilla/5.0 (X11; Linux ppc; rv:31.0) Gecko/20100101 Icedove/31.0 MIME-Version: 1.0 To: =?UTF-8?B?Q2hyaXN0aWFuIEvDtm5pZw==?= CC: Alex Deucher , Oded Gabbay , Andrew Lewycky , LKML , Maling list - DRI developers Subject: Re: [PATCH 02/83] drm/radeon: reduce number of free VMIDs and pipes in KV References: <1405029027-6085-1-git-send-email-oded.gabbay@amd.com> <20140711160516.GC1870@gmail.com> <53C00E6E.4040908@amd.com> <53C0F921.2030909@amd.com> In-Reply-To: <53C0F921.2030909@amd.com> X-Enigmail-Version: 1.6 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 12.07.2014 18:00, Christian König wrote: > Am 11.07.2014 18:22, schrieb Alex Deucher: >> On Fri, Jul 11, 2014 at 12:18 PM, Christian König >> wrote: >>> Am 11.07.2014 18:05, schrieb Jerome Glisse: >>> >>>> On Fri, Jul 11, 2014 at 12:50:02AM +0300, Oded Gabbay wrote: >>>>> To support HSA on KV, we need to limit the number of vmids and pipes >>>>> that are available for radeon's use with KV. >>>>> >>>>> This patch reserves VMIDs 8-15 for KFD (so radeon can only use VMIDs >>>>> 0-7) and also makes radeon thinks that KV has only a single MEC with a >>>>> single >>>>> pipe in it >>>>> >>>>> Signed-off-by: Oded Gabbay >>>> Reviewed-by: Jérôme Glisse >>> >>> At least fro the VMIDs on demand allocation should be trivial to >>> implement, >>> so I would rather prefer this instead of a fixed assignment. >> IIRC, the way the CP hw scheduler works you have to give it a range of >> vmids and it assigns them dynamically as queues are mapped so >> effectively they are potentially in use once the CP scheduler is set >> up. > > That's not what I meant. Changing it completely on the fly is nice to > have, but we should at least make it configurable as a module parameter. > > And even if we hardcode it we should use a define for it somewhere > instead of hardcoding 8 VMIDs on the KGD side and 8 VMIDs on KFD side > without any relation to each other. Seconded, and there should be more explanation and rationale for the way things are set up in the code or at least in the commit log. -- Earthling Michel Dänzer | http://www.amd.com Libre software enthusiast | Mesa and X developer