All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andrew Cooper <andrew.cooper3@citrix.com>
To: "Roger Pau Monné" <roger.pau@citrix.com>,
	xen-devel <xen-devel@lists.xen.org>,
	"Jan Beulich" <JBeulich@suse.com>, "Tim (Xen.org)" <tim@xen.org>,
	"Yang Zhang" <yang.z.zhang@intel.com>,
	"Kevin Tian" <kevin.tian@intel.com>, "Keir Fraser" <keir@xen.org>
Subject: Re: Commit dd6d87 breaks serial console
Date: Mon, 14 Jul 2014 17:25:12 +0100	[thread overview]
Message-ID: <53C40468.8030401@citrix.com> (raw)
In-Reply-To: <53C40054.8080400@citrix.com>

On 14/07/14 17:07, Roger Pau Monné wrote:
> Hello,
>
> The following commit:
>
> commit dd6d87a4fcc8350c752e389abb3bcd8479c37555
> Author: Jan Beulich <jbeulich@suse.com>
> Date:   Fri Jun 20 10:26:37 2014 +0200
>
>     VT-d: drop redundant calls to invalidate_sync()
>
>     The call tree iommu_flush_iec_index() -> __iommu_flush_iec() already
>     invokes invalidate_sync(). Removing the superfluous instances at once
>     allows the function to become static.
>
>     Signed-off-by: Jan Beulich <jbeulich@suse.com>
>     Reviewed-by: Andrew Cooper <andrew.cooper3@citrix.com>
>     Acked-by: Yang Zhang <yang.z.zhang@intel.com>
>
> Breaks serial console on my box, this is all the output I get with this 
> commit applied:

Are you sure you have bisected this correctly?

Unless there is some hardware side-effect of issuing two qinvalidate
wait descriptors back-to-back, the change still looks to be good. 
Alternately, are we missing a hardware erratum for your system?

~Andrew

  reply	other threads:[~2014-07-14 16:25 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-07-14 16:07 Commit dd6d87 breaks serial console Roger Pau Monné
2014-07-14 16:25 ` Andrew Cooper [this message]
2014-07-14 17:52   ` Roger Pau Monné
2014-07-15  1:24     ` Zhang, Yang Z
2014-07-23  8:31       ` Roger Pau Monné
2014-07-23  9:20         ` Jan Beulich
2014-07-23  8:20 ` Jan Beulich

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=53C40468.8030401@citrix.com \
    --to=andrew.cooper3@citrix.com \
    --cc=JBeulich@suse.com \
    --cc=keir@xen.org \
    --cc=kevin.tian@intel.com \
    --cc=roger.pau@citrix.com \
    --cc=tim@xen.org \
    --cc=xen-devel@lists.xen.org \
    --cc=yang.z.zhang@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.