From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pa0-f41.google.com (mail-pa0-f41.google.com [209.85.220.41]) by kanga.kvack.org (Postfix) with ESMTP id 967B06B0035 for ; Tue, 15 Jul 2014 00:47:18 -0400 (EDT) Received: by mail-pa0-f41.google.com with SMTP id fb1so6646947pad.0 for ; Mon, 14 Jul 2014 21:47:18 -0700 (PDT) Received: from mga02.intel.com (mga02.intel.com. [134.134.136.20]) by mx.google.com with ESMTP id mm9si10769608pbc.151.2014.07.14.21.47.16 for ; Mon, 14 Jul 2014 21:47:16 -0700 (PDT) Message-ID: <53C4B251.5000505@intel.com> Date: Mon, 14 Jul 2014 21:47:13 -0700 From: Dave Hansen MIME-Version: 1.0 Subject: Re: [patch] mm, thp: only collapse hugepages to nodes with affinity References: In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Sender: owner-linux-mm@kvack.org List-ID: To: David Rientjes , Andrew Morton Cc: Andrea Arcangeli , Mel Gorman , Rik van Riel , "Kirill A. Shutemov" , Bob Liu , linux-mm@kvack.org, linux-kernel@vger.kernel.org On 07/14/2014 06:09 PM, David Rientjes wrote: > + if (node == NUMA_NO_NODE) { > + node = page_to_nid(page); > + } else { > + int distance = node_distance(page_to_nid(page), node); > + > + /* > + * Do not migrate to memory that would not be reclaimed > + * from. > + */ > + if (distance > RECLAIM_DISTANCE) > + goto out_unmap; > + } Isn't the reclaim behavior based on zone_reclaim_mode and not RECLAIM_DISTANCE directly? And isn't that reclaim behavior disabled by default? I think you should at least be consulting zone_reclaim_mode. -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755495AbaGOErT (ORCPT ); Tue, 15 Jul 2014 00:47:19 -0400 Received: from mga09.intel.com ([134.134.136.24]:47563 "EHLO mga09.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751986AbaGOErQ (ORCPT ); Tue, 15 Jul 2014 00:47:16 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.01,662,1400050800"; d="scan'208";a="543404267" Message-ID: <53C4B251.5000505@intel.com> Date: Mon, 14 Jul 2014 21:47:13 -0700 From: Dave Hansen User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.6.0 MIME-Version: 1.0 To: David Rientjes , Andrew Morton CC: Andrea Arcangeli , Mel Gorman , Rik van Riel , "Kirill A. Shutemov" , Bob Liu , linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [patch] mm, thp: only collapse hugepages to nodes with affinity References: In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 07/14/2014 06:09 PM, David Rientjes wrote: > + if (node == NUMA_NO_NODE) { > + node = page_to_nid(page); > + } else { > + int distance = node_distance(page_to_nid(page), node); > + > + /* > + * Do not migrate to memory that would not be reclaimed > + * from. > + */ > + if (distance > RECLAIM_DISTANCE) > + goto out_unmap; > + } Isn't the reclaim behavior based on zone_reclaim_mode and not RECLAIM_DISTANCE directly? And isn't that reclaim behavior disabled by default? I think you should at least be consulting zone_reclaim_mode.