From: Johannes Sixt <j6t@kdbg.org>
To: Ephrim Khong <dr.khong@gmail.com>, Duy Nguyen <pclouds@gmail.com>,
GIT Mailing-list <git@vger.kernel.org>
Cc: Junio C Hamano <gitster@pobox.com>
Subject: Re: [PATCH v2] sha1_file: do not add own object directory as alternate
Date: Tue, 15 Jul 2014 07:44:39 +0200 [thread overview]
Message-ID: <53C4BFC7.2000507@kdbg.org> (raw)
In-Reply-To: <53C3D2AD.9050204@gmail.com>
Am 14.07.2014 14:53, schrieb Ephrim Khong:
> diff --git a/t/t7702-repack-cyclic-alternate.sh b/t/t7702-repack-cyclic-alternate.sh
> new file mode 100755
> index 0000000..3771613
> --- /dev/null
> +++ b/t/t7702-repack-cyclic-alternate.sh
> @@ -0,0 +1,24 @@
> +#!/bin/sh
> +#
> +# Copyright (c) 2014 Ephrim Khong
> +#
> +
> +test_description='repack involving cyclic alternate'
> +. ./test-lib.sh
> +
> +test_expect_success setup '
> + GIT_OBJECT_DIRECTORY=.git//../.git/objects &&
> + export GIT_OBJECT_DIRECTORY &&
> + touch a &&
> + git add a &&
> + git commit -m 1 &&
> + git repack -adl &&
> + echo $PWD/.git/objects/../objects > .git/objects/info/alternates
We need a Windows-style path in the file, double-quotes to protect
special characters, and a small style fix. Therefore:
echo "$(pwd)"/.git/objects/../objects >.git/objects/info/alternates
> +'
> +
> +test_expect_success 're-packing repository with itsself as alternate' '
> + git repack -adl &&
> + git fsck
> +'
> +
> +test_done
>
next prev parent reply other threads:[~2014-07-15 5:44 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-11 9:37 [Bug] data loss with cyclic alternates Ephrim Khong
2014-07-11 16:01 ` Junio C Hamano
2014-07-11 18:01 ` Keller, Jacob E
2014-07-12 5:57 ` Jeff King
2014-07-14 22:05 ` Keller, Jacob E
2014-07-13 10:44 ` Ephrim Khong
2014-07-14 9:02 ` [PATCH] sha1_file: do not add own object directory as alternate Ephrim Khong
2014-07-14 10:47 ` Duy Nguyen
2014-07-14 12:53 ` [PATCH v2] " Ephrim Khong
2014-07-15 5:44 ` Johannes Sixt [this message]
2014-07-15 11:29 ` [PATCH v3] " Ephrim Khong
2014-07-15 19:26 ` Junio C Hamano
2014-07-16 6:42 ` Ephrim Khong
2014-07-15 19:33 ` Eric Sunshine
2014-07-15 19:48 ` Junio C Hamano
2014-07-16 6:47 ` Ephrim Khong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53C4BFC7.2000507@kdbg.org \
--to=j6t@kdbg.org \
--cc=dr.khong@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=pclouds@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.