All of lore.kernel.org
 help / color / mirror / Atom feed
From: Deepak S <deepak.s@linux.intel.com>
To: intel-gfx <intel-gfx@lists.freedesktop.org>,
	ville.syrjala@linux.intel.com, jbarnes@virtuousgeek.org
Subject: Re: [PATCH v4] drm/i915: Force GPU Freq to lowest while suspending.
Date: Tue, 15 Jul 2014 13:05:48 +0530	[thread overview]
Message-ID: <53C4D9D4.2050808@linux.intel.com> (raw)
In-Reply-To: <1403274782-8437-1-git-send-email-deepak.s@linux.intel.com>


On Friday 20 June 2014 08:03 PM, deepak.s@linux.intel.com wrote:
> From: Deepak S <deepak.s@linux.intel.com>
>
> We might be leaving the GPU Frequency (and thus vnn) high during the suspend.
> Force gt to move to lowest freq while suspending.
>
> v2: Fixed typo in commit message (Deepak)
>
> v3: Force gt to lowest freq in suspend_gt_powersave (Daniel)
>
> v4: Add GPU min freq set _after_ we've cancelled the rps works (Daniel)
>
> Signed-off-by: Deepak S <deepak.s@linux.intel.com>
> ---
>   drivers/gpu/drm/i915/intel_pm.c | 3 +++
>   1 file changed, 3 insertions(+)
>
> diff --git a/drivers/gpu/drm/i915/intel_pm.c b/drivers/gpu/drm/i915/intel_pm.c
> index 2043c4b..0543407 100644
> --- a/drivers/gpu/drm/i915/intel_pm.c
> +++ b/drivers/gpu/drm/i915/intel_pm.c
> @@ -4884,6 +4884,9 @@ void intel_suspend_gt_powersave(struct drm_device *dev)
>   	flush_delayed_work(&dev_priv->rps.delayed_resume_work);
>   
>   	cancel_work_sync(&dev_priv->rps.work);
> +
> +	/* Force GPU to min freq during suspend */
> +	gen6_rps_idle(dev_priv);
>   }
>   
>   void intel_disable_gt_powersave(struct drm_device *dev)

Hi Jesse,

Please review the patch

Thanks
Deepak

  reply	other threads:[~2014-07-14  7:41 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-06-18  0:00 [PATCH v2] drm/i915: Bring GPU Freq to min while suspending deepak.s
2014-06-17 22:17 ` Daniel Vetter
2014-06-19  3:23   ` Deepak S
2014-06-18 10:48     ` Daniel Vetter
2014-06-20 11:59   ` [PATCH v3] drm/i915: Force GPU Freq to lowest " deepak.s
2014-06-19 12:34     ` Daniel Vetter
2014-06-20 14:25       ` Deepak S
2014-06-20 14:33       ` [PATCH v4] " deepak.s
2014-07-15  7:35         ` Deepak S [this message]
2014-07-14 15:17           ` Jesse Barnes
2014-07-16  3:21             ` Deepak S

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=53C4D9D4.2050808@linux.intel.com \
    --to=deepak.s@linux.intel.com \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=jbarnes@virtuousgeek.org \
    --cc=ville.syrjala@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.