All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jiri Slaby <jslaby@suse.cz>
To: "Li, ZhenHua" <zhen-hual@hp.com>,
	Peter Hurley <peter@hurleysoftware.com>
Cc: gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/1] driver/tty: Fix a warning in check_tty_count
Date: Tue, 15 Jul 2014 11:16:04 +0200	[thread overview]
Message-ID: <53C4F154.3000009@suse.cz> (raw)
In-Reply-To: <53C4EFA8.3080308@hp.com>

Hi,

On 07/15/2014 11:08 AM, Li, ZhenHua wrote:
> This bug  was founded in RHEL 6, kernel version 2.6.32.
> 
> But I also checked the file tty_io.c in  latest kernel, not all the code
> protected by tty_lock(tty).
> 
> For example,  in function tty_del_file,
> 
>     if (--tty->count < 0) {
>     }
> and
>     tty_del_file(filp);
> are not surrounded by tty_lock(tty).

Sure, but there is tty_lock_pair instead.

> So I think the new lock is necessary.

Nope, sorry, you have to complain to RedHat about this kernel. Unless
you can reproduce this with the vanilla kernel.

thanks,
-- 
js
suse labs

  reply	other threads:[~2014-07-15  9:16 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-07-14  5:54 [PATCH 1/1] driver/tty: Fix a warning in check_tty_count Li, Zhen-Hua
2014-07-14 12:25 ` Peter Hurley
2014-07-15  9:08   ` Li, ZhenHua
2014-07-15  9:16     ` Jiri Slaby [this message]
2014-07-16 10:36       ` Li, ZhenHua

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=53C4F154.3000009@suse.cz \
    --to=jslaby@suse.cz \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=peter@hurleysoftware.com \
    --cc=zhen-hual@hp.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.