From: Paolo Bonzini <pbonzini@redhat.com>
To: Amit Shah <amit.shah@redhat.com>, qemu list <qemu-devel@nongnu.org>
Cc: Amos Kong <akong@redhat.com>
Subject: Re: [Qemu-devel] [PATCH for-2.1 1/1] virtio-serial-bus: keep port 0 reserved for virtconsole even on unplug
Date: Tue, 15 Jul 2014 11:29:15 +0200 [thread overview]
Message-ID: <53C4F46B.4050602@redhat.com> (raw)
In-Reply-To: <965a31ed0c51f30c4e3a3a9df5db9c4892ec914e.1405416206.git.amit.shah@redhat.com>
Il 15/07/2014 11:23, Amit Shah ha scritto:
> i = port_id / 32;
This can also be moved inside the if.
Paolo
> - vser->ports_map[i] &= ~(1U << (port_id % 32));
> + if (port_id) {
> + /*
> + * Don't mark port 0 removed -- we explicitly reserve it for
> + * backward compat with older guests, and a device unplug of
> + * virtconsole removes the reservation.
> + */
> + vser->ports_map[i] &= ~(1U << (port_id % 32));
> + }
prev parent reply other threads:[~2014-07-15 9:29 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-15 9:23 [Qemu-devel] [PATCH for-2.1 1/1] virtio-serial-bus: keep port 0 reserved for virtconsole even on unplug Amit Shah
2014-07-15 9:29 ` Paolo Bonzini [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53C4F46B.4050602@redhat.com \
--to=pbonzini@redhat.com \
--cc=akong@redhat.com \
--cc=amit.shah@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.