All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ian Abbott <abbotti@mev.co.uk>
To: sam-the-6 <asadi.samuel@gmail.com>,
	<hsweeten@visionengravers.com>, <gregkh@linuxfoundation.org>
Cc: <devel@driverdev.osuosl.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 91/93] Staging: comedi: 8253.h fixed by removing 'return' from generic func
Date: Tue, 15 Jul 2014 11:16:48 +0100	[thread overview]
Message-ID: <53C4FF90.7070306@mev.co.uk> (raw)
In-Reply-To: <1405393999-25927-1-git-send-email-asadi.samuel@gmail.com>

On 2014-07-15 04:13, sam-the-6 wrote:
> From: Sam Asadi <asadi.samuel@gmail.com>
>
> Signed-off-by: Sam Asadi <asadi.samuel@gmail.com>
>
> 	modified:   drivers/staging/comedi/drivers/8253.h
> ---
>   drivers/staging/comedi/drivers/8253.h |    3 +--
>   1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/staging/comedi/drivers/8253.h b/drivers/staging/comedi/drivers/8253.h
> index 5829b46..f6b8607 100644
> --- a/drivers/staging/comedi/drivers/8253.h
> +++ b/drivers/staging/comedi/drivers/8253.h
> @@ -55,7 +55,7 @@ static inline void i8253_cascade_ns_to_timer(int i8253_osc_base,
>   	    /* check for overflow */
>   	    divider > div1 && divider > div2 &&
>   	    divider * i8253_osc_base > divider &&
> -	    divider * i8253_osc_base > i8253_osc_base) {
> +	    divider * i8253_osc_base > i8253_osc_base)	{

Keep the space before the '{'.  Don't replace it with a tab.

>   		return;
>   	}
>
> @@ -118,7 +118,6 @@ static inline void i8253_cascade_ns_to_timer(int i8253_osc_base,
>   	/*  masking is done since counter maps zero to 0x10000 */
>   	*d1 = div1 & 0xffff;
>   	*d2 = div2 & 0xffff;
> -	return;
>   }
>
>   #ifndef CMDTEST
>


-- 
-=( Ian Abbott @ MEV Ltd.    E-mail: <abbotti@mev.co.uk>        )=-
-=( Tel: +44 (0)161 477 1898   FAX: +44 (0)161 718 3587         )=-

  parent reply	other threads:[~2014-07-15 10:16 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-07-15  3:13 [PATCH 91/93] Staging: comedi: 8253.h fixed by removing 'return' from generic func sam-the-6
2014-07-15  7:07 ` Dan Carpenter
2014-07-15 10:16 ` Ian Abbott [this message]
2014-07-15 13:54 ` Greg KH

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=53C4FF90.7070306@mev.co.uk \
    --to=abbotti@mev.co.uk \
    --cc=asadi.samuel@gmail.com \
    --cc=devel@driverdev.osuosl.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=hsweeten@visionengravers.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.