From: Nikolay Aleksandrov <nikolay@redhat.com>
To: Eric Dumazet <edumazet@google.com>,
"David S. Miller" <davem@davemloft.net>
Cc: netdev@vger.kernel.org, Jay Vosburgh <j.vosburgh@gmail.com>,
Veaceslav Falico <vfalico@gmail.com>,
Andy Gospodarek <andy@greyhouse.net>,
Mahesh Bandewar <maheshb@google.com>
Subject: Re: [PATCH net-next 0/3] bonding: rcu cleanups
Date: Tue, 15 Jul 2014 12:55:19 +0200 [thread overview]
Message-ID: <53C50897.2020605@redhat.com> (raw)
In-Reply-To: <1405417604-7828-1-git-send-email-edumazet@google.com>
On 07/15/2014 11:46 AM, Eric Dumazet wrote:
> RCU was added to bonding in linux-3.12 but lacked proper sparse annotations.
>
> Using __rcu annotation actually helps to spot all accesses to bond->curr_active_slave
> are correctly protected, with full sparse & LOCKDEP support.
>
> Lets clean the code.
>
> Eric Dumazet (3):
> bonding: get rid of bond_option_active_slave_get()
> bonding: use rcu_access_pointer() in bonding_show_mii_status()
> bonding: add proper __rcu annotation for curr_active_slave
>
> drivers/net/bonding/bond_alb.c | 47 +++++++++++++++++++--------------
> drivers/net/bonding/bond_main.c | 53 +++++++++++++++++++++-----------------
> drivers/net/bonding/bond_netlink.c | 21 +++++++++++----
> drivers/net/bonding/bond_options.c | 7 +----
> drivers/net/bonding/bond_sysfs.c | 3 ++-
> drivers/net/bonding/bonding.h | 7 +++--
> 6 files changed, 81 insertions(+), 57 deletions(-)
>
Nice clean up, I also gave it a quick run. I believe similar clean up would
be beneficial for current_arp_slave at some point.
Anyhow, thanks Eric!
For the set
Reviewed-by: Nikolay Aleksandrov <nikolay@redhat.com>
next prev parent reply other threads:[~2014-07-15 10:55 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-15 9:46 [PATCH net-next 0/3] bonding: rcu cleanups Eric Dumazet
2014-07-15 9:46 ` [PATCH net-next 1/3] bonding: get rid of bond_option_active_slave_get() Eric Dumazet
2014-07-15 10:24 ` Veaceslav Falico
2014-07-15 9:46 ` [PATCH net-next 2/3] bonding: use rcu_access_pointer() in bonding_show_mii_status() Eric Dumazet
2014-07-15 10:32 ` Veaceslav Falico
2014-07-15 9:46 ` [PATCH net-next 3/3] bonding: add proper __rcu annotation for curr_active_slave Eric Dumazet
2014-07-15 10:38 ` Veaceslav Falico
2014-07-15 10:52 ` Eric Dumazet
2014-07-15 11:15 ` Veaceslav Falico
2014-07-15 10:55 ` Nikolay Aleksandrov [this message]
2014-07-15 11:51 ` [PATCH net-next 0/3] bonding: rcu cleanups Eric Dumazet
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53C50897.2020605@redhat.com \
--to=nikolay@redhat.com \
--cc=andy@greyhouse.net \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=j.vosburgh@gmail.com \
--cc=maheshb@google.com \
--cc=netdev@vger.kernel.org \
--cc=vfalico@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.