Re: [Qemu-devel] [PATCH v3 2/2] qapi: add read-pattern support for quorum

[Eric Blake <eblake@redhat.com>]

[-- Attachment #1: Type: text/plain, Size: 1142 bytes --]

On 07/15/2014 12:34 AM, Liu Yuan wrote:
> Cc: Eric Blake <eblake@redhat.com>
> Signed-off-by: Liu Yuan <namei.unix@gmail.com>
> ---
>  qapi/block-core.json | 19 ++++++++++++++++++-
>  1 file changed, 18 insertions(+), 1 deletion(-)
> 
> diff --git a/qapi/block-core.json b/qapi/block-core.json
> index e378653..22491bc 100644
> --- a/qapi/block-core.json
> +++ b/qapi/block-core.json
> @@ -1384,6 +1384,18 @@
>              'raw': 'BlockdevRef' } }
>  
>  ##
> +# @QuorumReadPattern
> +# An enumeration of quorum read pattern.

s/pattern/patterns/

> +#
> +# @quorum: read all the children and do a quorum vote on reads
> +#
> +# @fifo: read a single child and try next child in FIFO order if read fails.

Inconsistent on whether you are ending a line with '.'.  I'm not quite
sure if this reads well; maybe:

@fifo: read only from the first child that has not failed

I also wonder if 'single' might be a better name than 'fifo', especially
if we later add a 'round-robin' for read load balancing.

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 604 bytes --]