From mboxrd@z Thu Jan 1 00:00:00 1970 From: Chen Gang Subject: Re: [PATCH] drivers: Let several drivers depends on HAS_IOMEM for 'devm_ioremap_resource' Date: Tue, 15 Jul 2014 22:38:25 +0800 Message-ID: <53C53CE1.4090803@gmail.com> References: <201407130545.23004.marex@denx.de> <53C25551.1050909@nod.at> <53C288F0.3070001@metafoo.de> <53C28C4A.70907@nod.at> <53C29015.5070607@metafoo.de> <53C291C8.6050303@nod.at> <53C296C2.30304@metafoo.de> <20140713192202.GA19090@kroah.com> <53C2DF12.6040507@nod.at> <20140713201753.GA29955@kroah.com> <53C39569.9020802@nod.at> <53C3994C.1010309@metafoo.de> <53C39B66.4060500@nod.at> <5A40E1FC-CA61-4AFF-B205-4BAC175AA7AC@gmail.com> <53C47725.8000005@gmail.com> <53C47B76.4080306@roeck-us.net> <53C47FB7.6080304@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <53C47FB7.6080304@gmail.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: driverdev-devel-bounces@linuxdriverproject.org Sender: driverdev-devel-bounces@linuxdriverproject.org To: Guenter Roeck , Richard Weinberger Cc: linux-iio@vger.kernel.org, Benjamin Herrenschmidt , teg@jklm.no, Thierry Reding , Lennox Wu , Marek Vasut , Liqin Chen , Lars-Peter Clausen , Geert Uytterhoeven , msalter@redhat.com, linux-pwm@vger.kernel.org, devel@driverdev.osuosl.org, linux-watchdog@vger.kernel.org, arnd@arndb.de, linux-input@vger.kernel.org, Greg Kroah-Hartman , dmitry.torokhov@gmail.com, "linux-kernel@vger.kernel.org" , knaack.h@gmx.de, Martin Schwidefsky , Mischa.Jonker@synopsys.com, jic23@kernel.org List-Id: linux-input@vger.kernel.org T24gMDcvMTUvMjAxNCAwOToxMSBBTSwgQ2hlbiBHYW5nIHdyb3RlOgo+IAo+IAo+IE9uIDA3LzE1 LzIwMTQgMDg6NTMgQU0sIEd1ZW50ZXIgUm9lY2sgd3JvdGU6Cj4+IE9uIDA3LzE0LzIwMTQgMDU6 MzQgUE0sIENoZW4gR2FuZyB3cm90ZToKPj4+IE9uIDA3LzE0LzIwMTQgMDU6MjIgUE0sIENoZW4g R2FuZyB3cm90ZToKPj4+Pgo+Pj4+IOWcqCAyMDE05bm0N+aciDE05pel77yM5LiL5Y2INDo1N++8 jFJpY2hhcmQgV2VpbmJlcmdlciA8cmljaGFyZEBub2QuYXQ+IOWGmemBk++8mgo+Pj4+Cj4+Pj4+ IEFtIDE0LjA3LjIwMTQgMTA6NDgsIHNjaHJpZWIgTGFycy1QZXRlciBDbGF1c2VuOgo+Pj4+Pj4g T24gMDcvMTQvMjAxNCAxMDozMSBBTSwgUmljaGFyZCBXZWluYmVyZ2VyIHdyb3RlOgo+Pj4+Pj4+ IEFtIDEzLjA3LjIwMTQgMjI6MTcsIHNjaHJpZWIgR3JlZyBLcm9haC1IYXJ0bWFuOgo+Pj4+Pj4+ PiBPbiBTdW4sIEp1bCAxMywgMjAxNCBhdCAwOTozMzozOFBNICswMjAwLCBSaWNoYXJkIFdlaW5i ZXJnZXIgd3JvdGU6Cj4+Pj4+Pj4+PiBNYXliZSB3ZSBjb3VsZCBhZGQgQ09NUElMRV9URVNUIHRv IHRoZSB2ZXJzaW9uIHN0cmluZyB0b28/Cj4+Pj4+Pj4+PiBKdXN0IHRvIGRldGVjdCBzdWNoIGtl cm5lbHMgZmFzdCBpbiB1c2VyIGJ1ZyByZXBvcnRzLi4uCj4+Pj4+Pj4+Cj4+Pj4+Pj4+IFdoYXQg a2luZCBvZiBidWcgcmVwb3J0IGFyZSB5b3UgZ29pbmcgdG8gZ2V0Pwo+Pj4+Pj4+Cj4+Pj4+Pj4g VXNlciBtYW5hZ2VzIHRvIGVuYWJsZSBDT05GSUdfRk9PIGJ5IHNlbGVjdGluZyBDT01QSUxFX1RF U1QgYW5kCj4+Pj4+Pj4gY29tcGxhaW5zIHRoYXQgaXQgZG9lcyBub3Qgd29yay4gOikKPj4+Pj4+ Cj4+Pj4+PiBUaGVzZSBkcml2ZXJzIGFyZSB0eXBpY2FsbHkgZHJpdmVycyBmb3Igc29tZSBTb0Mg cGVyaXBoZXJhbCBhbmQgdGhlCj4+Pj4+PiBkZXZpY2Ugd2lsbCBzaW1wbHkgcGh5c2ljYWxseSBu b3QgZXhpc3Qgb24gYSBwbGF0Zm9ybSB0aGF0IGRvZXMgbm90Cj4+Pj4+PiBwcm92aWRlIEhBU19J T01FTS4gVGhpcyBpcyBub3QgcmVhbGx5IGFueQo+Pj4+Pj4gZGlmZmVyZW50IGZyb20gbWFraW5n IHRoZSBkcml2ZXIgc2VsZWN0YWJsZSB2aWEgQ09NUElMRV9URVNUIGZvcgo+Pj4+Pj4gYW55IG90 aGVyIHBsYXRmb3JtLiBUbyBoaXQgdGhlIGlzc3VlIHlvdSdkIGhhdmUgdG8gaW5zdGFudGlhdGUg YQo+Pj4+Pj4gZGV2aWNlIGRyaXZlciBpbnN0YW5jZSBmb3IgYSBkZXZpY2UgdGhhdAo+Pj4+Pj4g cGh5c2ljYWxseSBkb2VzIG5vdCBleGlzdC4gVGhpcyB3aWxsIGFsd2F5cyByZXN1bHQgaW4gYSBm YWlsdXJlLgo+Pj4+Pgo+Pj4+PiBPa2F5LCB5b3UgaGF2ZSBjb252aW5jZWQgbWUuIDopCj4+Pj4+ Cj4+Pgo+Pj4gQWZ0ZXIgc2VhcmNoIHRoZSBoaXN0b3J5IHBhdGNoZXMsIEkgZm91bmQgb25lIHJl bGF0ZWQgcGF0Y2ggd2hpY2ggbWFkZQo+Pj4gYnkgbXlzZWxmICh3aGVuIEkgYW0gaW4gQXNpYW51 eCk6Cj4+Pgo+Pj4gICAgImh0dHBzOi8vbGttbC5vcmcvbGttbC8yMDEzLzcvMS82NDEiCj4+Pgo+ Pj4gRm9yIG1lLCBpdCBpcyBhIGxvbmcgZGlzY3Vzc2lvbiwgYW5kIGZvcmNlZCBtYW55IG1lbWJl cnMgaGF2ZSB0byBqb2luCj4+PiBpbi4gUGxlYXNlIGhlbHAgY2hlY2sgYWdhaW4uCj4+Pgo+Pgo+ PiBPbmUgdGhpbmcgeW91IGNvdWxkIHRyeSB3b3VsZCBiZSB0byByZXR1cm4gTlVMTCAob3Igd2hl cmUgYXBwcm9wcmlhdGUKPj4gYW4gZXJyb3IpIGluIHRoZSAjZWxzZSBjYXNlIG9mIENPTkZJR19I QVNfSU9NRU0gYW5kIENPTkZJR19IQVNfSU9QT1JULAo+PiBpZSBkb250IHRha2UgQ09NUElMRV9U RVNUIGludG8gYWNjb3VudCBhdCBhbGwuIE9idmlvdXNseSB0aGF0IG1lYW5zCj4+IHlvdSB3b24n dCBiZSBhYmxlIHRvIGR1bXAgYSB3YXJuaW5nIG1lc3NhZ2UgaW4gdGhlIENPTVBJTEVfVEVTVAo+ PiBjYXNlLCBidXQgYXQgbGVhc3QgdGhlIGNvZGUgd291bGQgY29tcGlsZS4gVGhlIHJlamVjdGlv biBvZiBhYm92ZSBwYXRjaAo+PiB3b3VsZCBtYWtlIGEgZ29vZCBjYXNlIGZvciB0aGlzIGFwcHJv YWNoLgo+Pgo+IAo+IE9LLCB0aGFua3M6IGF0IGxlYXN0LCBpdCBjYW4gYmUgaW1wcm92ZWQuICBC dXQgc3RpbGwgd2VsY29tZSBhbnkgb3RoZXIKPiBvcGluaW9ucyBvZiBhbm90aGVyIHJlbGF0ZWQg bWVtYmVycy4KPiAKCklmIG5vIHJlcGx5IHdpdGhpbiAzIGRheXMgKDIwMTQtMDctMTgpLCBJIHNo YWxsIHRyeSB0byBzZW5kIHJlbGF0ZWQKcGF0Y2ggZm9yIGl0IHdpdGhpbiB0aGlzIHdlZWsgZW5k ICgyMDE0LTA3LTIwKS4KClRoYW5rcy4KLS0gCkNoZW4gR2FuZwoKT3BlbiBzaGFyZSBhbmQgYXR0 aXR1ZGUgbGlrZSBhaXIgd2F0ZXIgYW5kIGxpZmUgd2hpY2ggR29kIGJsZXNzZWQKX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZGV2ZWwgbWFpbGluZyBsaXN0 CmRldmVsQGxpbnV4ZHJpdmVycHJvamVjdC5vcmcKaHR0cDovL2RyaXZlcmRldi5saW51eGRyaXZl cnByb2plY3Qub3JnL21haWxtYW4vbGlzdGluZm8vZHJpdmVyZGV2LWRldmVsCg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pd0-f171.google.com ([209.85.192.171]:37964 "EHLO mail-pd0-f171.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753495AbaGOOic (ORCPT ); Tue, 15 Jul 2014 10:38:32 -0400 Message-ID: <53C53CE1.4090803@gmail.com> Date: Tue, 15 Jul 2014 22:38:25 +0800 From: Chen Gang MIME-Version: 1.0 To: Guenter Roeck , Richard Weinberger CC: Lars-Peter Clausen , Greg Kroah-Hartman , dmitry.torokhov@gmail.com, linux-iio@vger.kernel.org, Benjamin Herrenschmidt , teg@jklm.no, Thierry Reding , Lennox Wu , Marek Vasut , Liqin Chen , msalter@redhat.com, linux-pwm@vger.kernel.org, devel@driverdev.osuosl.org, linux-watchdog@vger.kernel.org, linux-input@vger.kernel.org, "linux-kernel@vger.kernel.org" , knaack.h@gmx.de, Martin Schwidefsky , Mischa.Jonker@synopsys.com, jic23@kernel.org, arnd@arndb.de, Geert Uytterhoeven Subject: Re: [PATCH] drivers: Let several drivers depends on HAS_IOMEM for 'devm_ioremap_resource' References: <201407130545.23004.marex@denx.de> <53C25551.1050909@nod.at> <53C288F0.3070001@metafoo.de> <53C28C4A.70907@nod.at> <53C29015.5070607@metafoo.de> <53C291C8.6050303@nod.at> <53C296C2.30304@metafoo.de> <20140713192202.GA19090@kroah.com> <53C2DF12.6040507@nod.at> <20140713201753.GA29955@kroah.com> <53C39569.9020802@nod.at> <53C3994C.1010309@metafoo.de> <53C39B66.4060500@nod.at> <5A40E1FC-CA61-4AFF-B205-4BAC175AA7AC@gmail.com> <53C47725.8000005@gmail.com> <53C47B76.4080306@roeck-us.net> <53C47FB7.6080304@gmail.com> In-Reply-To: <53C47FB7.6080304@gmail.com> Content-Type: text/plain; charset=UTF-8 Sender: linux-iio-owner@vger.kernel.org List-Id: linux-iio@vger.kernel.org On 07/15/2014 09:11 AM, Chen Gang wrote: > > > On 07/15/2014 08:53 AM, Guenter Roeck wrote: >> On 07/14/2014 05:34 PM, Chen Gang wrote: >>> On 07/14/2014 05:22 PM, Chen Gang wrote: >>>> >>>> 在 2014年7月14日，下午4:57，Richard Weinberger 写道： >>>> >>>>> Am 14.07.2014 10:48, schrieb Lars-Peter Clausen: >>>>>> On 07/14/2014 10:31 AM, Richard Weinberger wrote: >>>>>>> Am 13.07.2014 22:17, schrieb Greg Kroah-Hartman: >>>>>>>> On Sun, Jul 13, 2014 at 09:33:38PM +0200, Richard Weinberger wrote: >>>>>>>>> Maybe we could add COMPILE_TEST to the version string too? >>>>>>>>> Just to detect such kernels fast in user bug reports... >>>>>>>> >>>>>>>> What kind of bug report are you going to get? >>>>>>> >>>>>>> User manages to enable CONFIG_FOO by selecting COMPILE_TEST and >>>>>>> complains that it does not work. :) >>>>>> >>>>>> These drivers are typically drivers for some SoC peripheral and the >>>>>> device will simply physically not exist on a platform that does not >>>>>> provide HAS_IOMEM. This is not really any >>>>>> different from making the driver selectable via COMPILE_TEST for >>>>>> any other platform. To hit the issue you'd have to instantiate a >>>>>> device driver instance for a device that >>>>>> physically does not exist. This will always result in a failure. >>>>> >>>>> Okay, you have convinced me. :) >>>>> >>> >>> After search the history patches, I found one related patch which made >>> by myself (when I am in Asianux): >>> >>> "https://lkml.org/lkml/2013/7/1/641" >>> >>> For me, it is a long discussion, and forced many members have to join >>> in. Please help check again. >>> >> >> One thing you could try would be to return NULL (or where appropriate >> an error) in the #else case of CONFIG_HAS_IOMEM and CONFIG_HAS_IOPORT, >> ie dont take COMPILE_TEST into account at all. Obviously that means >> you won't be able to dump a warning message in the COMPILE_TEST >> case, but at least the code would compile. The rejection of above patch >> would make a good case for this approach. >> > > OK, thanks: at least, it can be improved. But still welcome any other > opinions of another related members. > If no reply within 3 days (2014-07-18), I shall try to send related patch for it within this week end (2014-07-20). Thanks. -- Chen Gang Open share and attitude like air water and life which God blessed From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from mail-pd0-f171.google.com ([209.85.192.171]:37964 "EHLO mail-pd0-f171.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753495AbaGOOic (ORCPT ); Tue, 15 Jul 2014 10:38:32 -0400 Message-ID: <53C53CE1.4090803@gmail.com> Date: Tue, 15 Jul 2014 22:38:25 +0800 From: Chen Gang MIME-Version: 1.0 To: Guenter Roeck , Richard Weinberger CC: Lars-Peter Clausen , Greg Kroah-Hartman , dmitry.torokhov@gmail.com, linux-iio@vger.kernel.org, Benjamin Herrenschmidt , teg@jklm.no, Thierry Reding , Lennox Wu , Marek Vasut , Liqin Chen , msalter@redhat.com, linux-pwm@vger.kernel.org, devel@driverdev.osuosl.org, linux-watchdog@vger.kernel.org, linux-input@vger.kernel.org, "linux-kernel@vger.kernel.org" , knaack.h@gmx.de, Martin Schwidefsky , Mischa.Jonker@synopsys.com, jic23@kernel.org, arnd@arndb.de, Geert Uytterhoeven Subject: Re: [PATCH] drivers: Let several drivers depends on HAS_IOMEM for 'devm_ioremap_resource' References: <201407130545.23004.marex@denx.de> <53C25551.1050909@nod.at> <53C288F0.3070001@metafoo.de> <53C28C4A.70907@nod.at> <53C29015.5070607@metafoo.de> <53C291C8.6050303@nod.at> <53C296C2.30304@metafoo.de> <20140713192202.GA19090@kroah.com> <53C2DF12.6040507@nod.at> <20140713201753.GA29955@kroah.com> <53C39569.9020802@nod.at> <53C3994C.1010309@metafoo.de> <53C39B66.4060500@nod.at> <5A40E1FC-CA61-4AFF-B205-4BAC175AA7AC@gmail.com> <53C47725.8000005@gmail.com> <53C47B76.4080306@roeck-us.net> <53C47FB7.6080304@gmail.com> In-Reply-To: <53C47FB7.6080304@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Sender: linux-watchdog-owner@vger.kernel.org List-Id: linux-watchdog@vger.kernel.org On 07/15/2014 09:11 AM, Chen Gang wrote: >=20 >=20 > On 07/15/2014 08:53 AM, Guenter Roeck wrote: >> On 07/14/2014 05:34 PM, Chen Gang wrote: >>> On 07/14/2014 05:22 PM, Chen Gang wrote: >>>> >>>> =E5=9C=A8 2014=E5=B9=B47=E6=9C=8814=E6=97=A5=EF=BC=8C=E4=B8=8B=E5=8D= =884:57=EF=BC=8CRichard Weinberger =E5=86=99=E9=81=93=EF= =BC=9A >>>> >>>>> Am 14.07.2014 10:48, schrieb Lars-Peter Clausen: >>>>>> On 07/14/2014 10:31 AM, Richard Weinberger wrote: >>>>>>> Am 13.07.2014 22:17, schrieb Greg Kroah-Hartman: >>>>>>>> On Sun, Jul 13, 2014 at 09:33:38PM +0200, Richard Weinberger w= rote: >>>>>>>>> Maybe we could add COMPILE_TEST to the version string too? >>>>>>>>> Just to detect such kernels fast in user bug reports... >>>>>>>> >>>>>>>> What kind of bug report are you going to get? >>>>>>> >>>>>>> User manages to enable CONFIG_FOO by selecting COMPILE_TEST and >>>>>>> complains that it does not work. :) >>>>>> >>>>>> These drivers are typically drivers for some SoC peripheral and = the >>>>>> device will simply physically not exist on a platform that does = not >>>>>> provide HAS_IOMEM. This is not really any >>>>>> different from making the driver selectable via COMPILE_TEST for >>>>>> any other platform. To hit the issue you'd have to instantiate a >>>>>> device driver instance for a device that >>>>>> physically does not exist. This will always result in a failure. >>>>> >>>>> Okay, you have convinced me. :) >>>>> >>> >>> After search the history patches, I found one related patch which m= ade >>> by myself (when I am in Asianux): >>> >>> "https://lkml.org/lkml/2013/7/1/641" >>> >>> For me, it is a long discussion, and forced many members have to jo= in >>> in. Please help check again. >>> >> >> One thing you could try would be to return NULL (or where appropriat= e >> an error) in the #else case of CONFIG_HAS_IOMEM and CONFIG_HAS_IOPOR= T, >> ie dont take COMPILE_TEST into account at all. Obviously that means >> you won't be able to dump a warning message in the COMPILE_TEST >> case, but at least the code would compile. The rejection of above pa= tch >> would make a good case for this approach. >> >=20 > OK, thanks: at least, it can be improved. But still welcome any othe= r > opinions of another related members. >=20 If no reply within 3 days (2014-07-18), I shall try to send related patch for it within this week end (2014-07-20). Thanks. --=20 Chen Gang Open share and attitude like air water and life which God blessed -- To unsubscribe from this list: send the line "unsubscribe linux-watchdo= g" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html