From mboxrd@z Thu Jan 1 00:00:00 1970 From: Kukjin Kim Subject: Re: [PATCH 2/6] ARM: EXYNOS: Fix core ID used by platsmp and hotplug code Date: Wed, 16 Jul 2014 03:00:12 +0900 Message-ID: <53C56C2C.8010801@samsung.com> References: <1403618235-19353-1-git-send-email-t.figa@samsung.com> <1403618235-19353-3-git-send-email-t.figa@samsung.com> <031001cf9aaf$959cf6c0$c0d6e440$@samsung.com> <53C3A7FE.8000401@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Return-path: Received: from mail-pa0-f45.google.com ([209.85.220.45]:32848 "EHLO mail-pa0-f45.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754038AbaGOSAU (ORCPT ); Tue, 15 Jul 2014 14:00:20 -0400 In-Reply-To: <53C3A7FE.8000401@gmail.com> Sender: linux-samsung-soc-owner@vger.kernel.org List-Id: linux-samsung-soc@vger.kernel.org To: Tomasz Figa Cc: Kukjin Kim , 'Tomasz Figa' , linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, 'Marek Szyprowski' On 07/14/14 18:50, Tomasz Figa wrote: > Hi Kukjin, > Hi, > On 08.07.2014 15:21, Kukjin Kim wrote: >> Tomasz Figa wrote: >>> >>> When CPU topology is specified in device tree, cpu_logical_map() does >>> not return core ID anymore, but rather full MPIDR value. This breaks >>> existing calculation of PMU register offsets on Exynos SoCs. >>> >>> This patch fixes the problem by adjusting the code to use only core ID >>> bits of the value returned by cpu_logical_map() to allow CPU topology to >>> be specified in device tree on Exynos SoCs. >>> >>> Signed-off-by: Tomasz Figa >> >> Looks good to me, but I think we don't need this fix in 3.16 because the CPU >> topology is not specified in DT yet...if I'm wrong, please correct me. > > CPU topology is already specified in DT for Exynos3250, 5250, 5260, 5410 > and 5420/5800. > > This patch also fixes CPU hotplug on SoCs with more than 2 cores, > because it removes incorrect condition check in platform_do_lowpower(). > > Please take this fix for next -rc release. > Agreed and I've applied this into fixes for 3.16... Thanks, Kukjin From mboxrd@z Thu Jan 1 00:00:00 1970 From: kgene.kim@samsung.com (Kukjin Kim) Date: Wed, 16 Jul 2014 03:00:12 +0900 Subject: [PATCH 2/6] ARM: EXYNOS: Fix core ID used by platsmp and hotplug code In-Reply-To: <53C3A7FE.8000401@gmail.com> References: <1403618235-19353-1-git-send-email-t.figa@samsung.com> <1403618235-19353-3-git-send-email-t.figa@samsung.com> <031001cf9aaf$959cf6c0$c0d6e440$@samsung.com> <53C3A7FE.8000401@gmail.com> Message-ID: <53C56C2C.8010801@samsung.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 07/14/14 18:50, Tomasz Figa wrote: > Hi Kukjin, > Hi, > On 08.07.2014 15:21, Kukjin Kim wrote: >> Tomasz Figa wrote: >>> >>> When CPU topology is specified in device tree, cpu_logical_map() does >>> not return core ID anymore, but rather full MPIDR value. This breaks >>> existing calculation of PMU register offsets on Exynos SoCs. >>> >>> This patch fixes the problem by adjusting the code to use only core ID >>> bits of the value returned by cpu_logical_map() to allow CPU topology to >>> be specified in device tree on Exynos SoCs. >>> >>> Signed-off-by: Tomasz Figa >> >> Looks good to me, but I think we don't need this fix in 3.16 because the CPU >> topology is not specified in DT yet...if I'm wrong, please correct me. > > CPU topology is already specified in DT for Exynos3250, 5250, 5260, 5410 > and 5420/5800. > > This patch also fixes CPU hotplug on SoCs with more than 2 cores, > because it removes incorrect condition check in platform_do_lowpower(). > > Please take this fix for next -rc release. > Agreed and I've applied this into fixes for 3.16... Thanks, Kukjin