From: Waiman Long <waiman.long@hp.com>
To: Peter Zijlstra <peterz@infradead.org>
Cc: Ingo Molnar <mingo@kernel.org>,
Maarten Lankhorst <maarten.lankhorst@canonical.com>,
Rik van Riel <riel@redhat.com>,
linux-kernel@vger.kernel.org,
Scott J Norton <scott.norton@hp.com>,
Fengguang Wu <fengguang.wu@intel.com>
Subject: Re: [PATCH v5 0/2] lockdep: add support for queued rwlock
Date: Tue, 15 Jul 2014 15:19:59 -0400 [thread overview]
Message-ID: <53C57EDF.2090107@hp.com> (raw)
In-Reply-To: <20140707125012.GP6758@twins.programming.kicks-ass.net>
On 07/07/2014 08:50 AM, Peter Zijlstra wrote:
> On Thu, Jun 26, 2014 at 01:39:09PM -0400, Waiman Long wrote:
>> v4->v5:
>> - Add patch 2 to update the locking selftest code to handle recursive
>> read_lock correctly. Patch 1 has no change.
> I removed all CONFIG_QUEUE_RWLOCK dependencies and made lockdep
> unconditionally assume the stronger constraints.
>
> Since we want all code 'clean' for the strongest possible
> implementation, everybody should run with those semantics, it doesn't
> make sense to have that configurable.
>
> Eg. someone on (say ARM, which doesn't -- yet -- have QUEUE_RWLOCK)
> could unwittingly introduce faulty code.
I think this is a better way to go. I didn't take this way in my patch
for fear that I may be pushing too much.
-Longman
prev parent reply other threads:[~2014-07-15 19:20 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-26 17:39 [PATCH v5 0/2] lockdep: add support for queued rwlock Waiman Long
2014-06-26 17:39 ` [PATCH v5 1/2] lockdep: restrict the use of recursive read_lock with qrwlock Waiman Long
2014-07-17 11:00 ` [tip:locking/core] locking/lockdep: Restrict the use of recursive read_lock() " tip-bot for Waiman Long
2014-06-26 17:39 ` [PATCH v5 2/2] locking-selftest: Support queue rwlock Waiman Long
2014-07-17 11:00 ` [tip:locking/core] locking/selftest: Support queued rwlock tip-bot for Waiman Long
2014-07-07 12:50 ` [PATCH v5 0/2] lockdep: add support for " Peter Zijlstra
2014-07-15 19:19 ` Waiman Long [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53C57EDF.2090107@hp.com \
--to=waiman.long@hp.com \
--cc=fengguang.wu@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=maarten.lankhorst@canonical.com \
--cc=mingo@kernel.org \
--cc=peterz@infradead.org \
--cc=riel@redhat.com \
--cc=scott.norton@hp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.