From: Matthias Schwarzott <zzam@gentoo.org>
To: Antti Palosaari <crope@iki.fi>
Cc: Linux Media Mailing List <linux-media@vger.kernel.org>
Subject: Re: [PATCH 1/2] si2157: Add support for spectrum inversion
Date: Tue, 15 Jul 2014 21:26:31 +0200 [thread overview]
Message-ID: <53C58067.8000601@gentoo.org> (raw)
In-Reply-To: <53C50BA0.2000800@iki.fi>
On 15.07.2014 13:08, Antti Palosaari wrote:
> Moikka Matthias!
> Idea of patch is correct, but I think implementation not. You set FE to
> si2157_config on variable define, but on that point FE is NULL. FE
> pointer is populated by demodulator driver, si2168. Right?
Right, I looked into si2168_probe, it sets this pointer.
>
> And you could split that to 3 patches too, one for prepare em28xx, one
> for cxusb and last is patch itself.
Yes, I split it accordingly.
Here is the new series based on the silabs branch.
Btw. When will these patches be merged to the master branch?
Regards
Matthias
next prev parent reply other threads:[~2014-07-15 19:26 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1405411120-9569-1-git-send-email-zzam@gentoo.org>
2014-07-15 7:58 ` [PATCH 1/2] si2157: Add support for spectrum inversion Matthias Schwarzott
2014-07-15 11:08 ` Antti Palosaari
2014-07-15 19:26 ` Matthias Schwarzott [this message]
2014-07-15 19:34 ` [PATCH 1/3] cxusb: Prepare for si2157 driver getting more parameters Matthias Schwarzott
2014-07-19 2:15 ` Antti Palosaari
2014-07-15 19:34 ` [PATCH 2/3] em28xx-dvb: " Matthias Schwarzott
2014-07-19 2:16 ` Antti Palosaari
2014-07-15 19:34 ` [PATCH 3/3] si2157: Add support for spectral inversion Matthias Schwarzott
2014-07-19 2:25 ` Antti Palosaari
2014-07-15 7:58 ` [PATCH 2/2] si2157: Add get_if_frequency callback Matthias Schwarzott
2014-07-15 11:08 ` Antti Palosaari
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53C58067.8000601@gentoo.org \
--to=zzam@gentoo.org \
--cc=crope@iki.fi \
--cc=linux-media@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.