From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by yocto-www.yoctoproject.org (Postfix, from userid 118) id 93E77E00543; Tue, 15 Jul 2014 13:50:37 -0700 (PDT) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on yocto-www.yoctoproject.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_NONE autolearn=ham version=3.3.1 X-Spam-HAM-Report: * -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at http://www.dnswl.org/, no * trust * [209.85.192.171 listed in list.dnswl.org] * -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% * [score: 0.0000] Received: from mail-pd0-f171.google.com (mail-pd0-f171.google.com [209.85.192.171]) by yocto-www.yoctoproject.org (Postfix) with ESMTP id 706F6E003D8 for ; Tue, 15 Jul 2014 13:50:32 -0700 (PDT) Received: by mail-pd0-f171.google.com with SMTP id z10so5474839pdj.30 for ; Tue, 15 Jul 2014 13:50:31 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:message-id:date:from:user-agent:mime-version:to :subject:references:in-reply-to:content-type :content-transfer-encoding; bh=+yzbfgPSuURB7f0Zyr/B8Q4pAyMwuicdkCC/ffDMTMI=; b=TJ8UNSGCWFiwXO9htyWnTPiwOpiAZERJsH6LykrOyvjfVAAwFDjXaJyThKhrMt6+R+ bzB7O7N7fWuMEqhkrcK0oNc4cFNLsZfMH10e6WUpWzDasSDdJb6w63RaKY4HCUGztInb cMKC8jhIilvjZlFxttLLCPfDRPEbH/lUmc3g7sikMuxZUW2t5yO59KYEnj3qcePd7/0W VkKLhg7oSYrQjVEGbQrbJtXrxnBixXT8A8YRMJXy3PImz2dasVrKQA4E1CVC/IOKznAg h1mMeXA40BIgtzYPKPKFqKOV5h+QgguMBA0qVb6r5m7PgcqP0+HbskWJE367KoTpWKhB RwcA== X-Gm-Message-State: ALoCoQkrIAMnj2CtUlkhkaWe7jrtgli4a4Wdy8NfhflnYWhAgMXlAhNoWuAiafxWZXdwQns98+L/ X-Received: by 10.66.150.228 with SMTP id ul4mr25290419pab.16.1405457431488; Tue, 15 Jul 2014 13:50:31 -0700 (PDT) Received: from [192.168.1.11] ([63.226.49.26]) by mx.google.com with ESMTPSA id s6sm19843086pdl.32.2014.07.15.13.50.29 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Tue, 15 Jul 2014 13:50:30 -0700 (PDT) Message-ID: <53C59414.2050807@boundarydevices.com> Date: Tue, 15 Jul 2014 13:50:28 -0700 From: Eric Nelson User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.6.0 MIME-Version: 1.0 To: John Weber , meta-freescale@yoctoproject.org References: <1405454473-16252-1-git-send-email-rjohnweber@gmail.com> <1405454473-16252-3-git-send-email-rjohnweber@gmail.com> In-Reply-To: <1405454473-16252-3-git-send-email-rjohnweber@gmail.com> X-Enigmail-Version: 1.6 Subject: Re: [meta-fsl-arm-extra][PATCH 3/4] linux-firmware: add bbappend to modify firmware file names X-BeenThere: meta-freescale@yoctoproject.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: Usage and development list for the meta-fsl-* layers List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 15 Jul 2014 20:50:37 -0000 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Hi John, On 07/15/2014 01:01 PM, John Weber wrote: > Upstream changes to the brcmfmac driver require a change to the firmware > file names to match the devid and interface type of the Broadcom chipset. > This also makes it easier for one machine to support multiple chipets in > Yocto. > > Signed-off-by: John Weber > --- > .../linux-firmware/linux-firmware_git.bbappend | 32 ++++++++++++++++++++++ > 1 file changed, 32 insertions(+) > create mode 100644 recipes-kernel/linux-firmware/linux-firmware_git.bbappend > > diff --git a/recipes-kernel/linux-firmware/linux-firmware_git.bbappend b/recipes-kernel/linux-firmware/linux-firmware_git.bbappend > new file mode 100644 > index 0000000..84b5fab > --- /dev/null > +++ b/recipes-kernel/linux-firmware/linux-firmware_git.bbappend > @@ -0,0 +1,32 @@ > +BRCM_FWDIR = "/lib/firmware/brcm" > + > +do_install_append () { > + # rename downloaded files so that we can create alternative > + # links > + > + cd ${D}${BRCM_FWDIR} > + > + mv brcmfmac4329-sdio.bin brcmfmac4329-sta-sdio.bin > + mv brcmfmac4330-sdio.bin brcmfmac4330-sta-sdio.bin > + Nice! It looks like you figured out a way to make this backward compatible so that you're not waiting on me! > + # Create original file links, so that the base recipe sees the installed files > + ln -sf brcmfmac4329-sta-sdio.bin brcmfmac4329-sdio.bin > + ln -sf brcmfmac4330-sta-sdio.bin brcmfmac4330-sdio.bin > +} > + > +FILES_${PN}-bcm4329 += " \ > + ${BRCM_FWDIR}/brcmfmac4329-sta-sdio.bin \ > +" > + > +FILES_${PN}-bcm4330 += " \ > + ${BRCM_FWDIR}/brcmfmac4330-sta-sdio.bin \ > +" > + > +ALTERNATIVE_linux-firmware-bcm4329 += " brcmfmac4329-sdio.bin" > +ALTERNATIVE_LINK_NAME[brcmfmac4329-sdio.bin] = "${BRCM_FWDIR}/brcmfmac4329-sdio.bin" > +ALTERNATIVE_TARGET_linux-firmware-bcm4329[brcmfmac4329-sdio.bin] = "${BRCM_FWDIR}/brcmfmac4329-sta-sdio.bin" > + > +ALTERNATIVE_linux-firmware-bcm4330 += " brcmfmac4330-sdio.bin" > +ALTERNATIVE_LINK_NAME[brcmfmac4330-sdio.bin] = "${BRCM_FWDIR}/brcmfmac4330-sdio.bin" > +ALTERNATIVE_TARGET_linux-firmware-bcm4330[brcmfmac4330-sdio.bin] = "${BRCM_FWDIR}/brcmfmac4330-sta-sdio.bin" > + > Acked-by: Eric Nelson